Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1908963002: [turbofan] Make pure JS operators effectful before first scheduler. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make pure JS operators effectful before first scheduler. This way the first scheduler can properly wire them to the effect chain, as otherwise the second scheduler could schedule them such that they would be able to read uninitialized memory (once we drop the region protection in the first scheduler). R=jarin@chromium.org Committed: https://crrev.com/9bac40157f823584bd2ed119a8cec4c95b50f94e Cr-Commit-Position: refs/heads/master@{#35707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M src/compiler/js-generic-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 3 chunks +29 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-21 13:00:10 UTC) #1
Benedikt Meurer
Hey Jaro, Next step in wiring everything :-) Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-21 13:00:51 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-21 13:16:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908963002/1
4 years, 8 months ago (2016-04-21 13:28:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 13:30:44 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bac40157f823584bd2ed119a8cec4c95b50f94e
Cr-Commit-Position: refs/heads/master@{#35707}

Powered by Google App Engine
This is Rietveld 408576698