Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: extensions/common/url_pattern_set_unittest.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/url_pattern_set.cc ('k') | extensions/common/url_pattern_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/url_pattern_set_unittest.cc
diff --git a/extensions/common/url_pattern_set_unittest.cc b/extensions/common/url_pattern_set_unittest.cc
index 4d3af98bf6892d269962e5bd275d3a683ddf4402..bbb72aa7c5dc77927a181e128368fddb1280b018 100644
--- a/extensions/common/url_pattern_set_unittest.cc
+++ b/extensions/common/url_pattern_set_unittest.cc
@@ -286,7 +286,7 @@ TEST(URLPatternSetTest, ToValueAndPopulate) {
std::string error;
bool allow_file_access = false;
- scoped_ptr<base::ListValue> value(set1.ToValue());
+ std::unique_ptr<base::ListValue> value(set1.ToValue());
set2.Populate(*value, URLPattern::SCHEME_ALL, allow_file_access, &error);
EXPECT_EQ(set1, set2);
@@ -463,7 +463,7 @@ TEST(URLPatternSetTest, ToStringVector) {
AddPattern(&set, "https://google.com/");
AddPattern(&set, "https://yahoo.com/");
- scoped_ptr<std::vector<std::string>> string_vector(set.ToStringVector());
+ std::unique_ptr<std::vector<std::string>> string_vector(set.ToStringVector());
EXPECT_EQ(2UL, string_vector->size());
« no previous file with comments | « extensions/common/url_pattern_set.cc ('k') | extensions/common/url_pattern_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698