Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: extensions/common/manifest_handlers/webview_info.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_handlers/webview_info.h ('k') | extensions/common/manifest_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/webview_info.cc
diff --git a/extensions/common/manifest_handlers/webview_info.cc b/extensions/common/manifest_handlers/webview_info.cc
index 6775c754dbc151b64d06538977488a91175b3d43..989df762b45c2cdbd167bcb855618952c5230a20 100644
--- a/extensions/common/manifest_handlers/webview_info.cc
+++ b/extensions/common/manifest_handlers/webview_info.cc
@@ -6,9 +6,9 @@
#include <stddef.h>
+#include <memory>
#include <utility>
-#include "base/memory/scoped_ptr.h"
#include "base/strings/pattern.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -86,7 +86,7 @@ bool WebviewInfo::IsResourceWebviewAccessible(
return false;
}
-void WebviewInfo::AddPartitionItem(scoped_ptr<PartitionItem> item) {
+void WebviewInfo::AddPartitionItem(std::unique_ptr<PartitionItem> item) {
partition_items_.push_back(std::move(item));
}
@@ -97,7 +97,7 @@ WebviewHandler::~WebviewHandler() {
}
bool WebviewHandler::Parse(Extension* extension, base::string16* error) {
- scoped_ptr<WebviewInfo> info(new WebviewInfo(extension->id()));
+ std::unique_ptr<WebviewInfo> info(new WebviewInfo(extension->id()));
const base::DictionaryValue* dict_value = NULL;
if (!extension->manifest()->GetDictionary(keys::kWebview,
@@ -148,7 +148,7 @@ bool WebviewHandler::Parse(Extension* extension, base::string16* error) {
return false;
}
- scoped_ptr<PartitionItem> partition_item(
+ std::unique_ptr<PartitionItem> partition_item(
new PartitionItem(partition_pattern));
for (size_t i = 0; i < url_list->GetSize(); ++i) {
« no previous file with comments | « extensions/common/manifest_handlers/webview_info.h ('k') | extensions/common/manifest_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698