Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: tests/lib/convert/close_test.dart

Issue 1908943004: Fix void foo(..) => ... to use { } instead. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Upload Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/websocket_impl.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/convert/close_test.dart
diff --git a/tests/lib/convert/close_test.dart b/tests/lib/convert/close_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..541c1fa6eb164d0dd1f95168ef70cbb296252c16
--- /dev/null
+++ b/tests/lib/convert/close_test.dart
@@ -0,0 +1,33 @@
+// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+import "dart:convert";
+
+class MySink implements Sink<List<int>> {
+ List<int> accumulated = <int>[];
+ bool isClosed = false;
+
+ add(List<int> list) {
+ accumulated.addAll(list);
+ return list.length;
+ }
+
+ close() {
+ isClosed = true;
+ // Returning a value here triggered a bug, where the caller was trying to
+ // pass the value through its 'void' return type.
+ // Example: void close() => _sink.close();
+ return "done";
+ }
+}
+
+main() {
+ var mySink = new MySink();
+ var byteSink = new ByteConversionSink.from(mySink);
+ byteSink.add([1, 2, 3]);
+ byteSink.close();
+ Expect.listEquals([1, 2, 3], mySink.accumulated);
+ Expect.isTrue(mySink.isClosed);
+}
« no previous file with comments | « sdk/lib/io/websocket_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698