Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1908943004: Fix void foo(..) => ... to use { } instead. (Closed)

Created:
4 years, 8 months ago by floitsch
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix void foo(..) => ... to use { } instead. Fixes issue 26292. BUG= http://dartbug.com/26292 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/1e574a1ffc84036b3ce6d4103a685f8b77bb096e

Patch Set 1 #

Patch Set 2 : Upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -58 lines) Patch
M sdk/lib/async/stream.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/async/stream_transformers.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M sdk/lib/convert/byte_conversion.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/convert/chunked_conversion.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/convert/html_escape.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/string_conversion.dart View 5 chunks +11 lines, -10 lines 0 comments Download
M sdk/lib/io/bytes_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 5 chunks +17 lines, -13 lines 0 comments Download
M sdk/lib/io/http_session.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/io_resource_info.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 3 chunks +11 lines, -8 lines 0 comments Download
A tests/lib/convert/close_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 8 months ago (2016-04-21 15:33:47 UTC) #2
Lasse Reichstein Nielsen
LGTM, STV!
4 years, 8 months ago (2016-04-21 17:29:33 UTC) #3
floitsch
4 years, 8 months ago (2016-04-21 19:35:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1e574a1ffc84036b3ce6d4103a685f8b77bb096e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698