Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1908913002: Revert of mus: Fix event transformation in client code. (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, kalyank, sadrul, tfarina, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mus: Fix event transformation in client code. (patchset #3 id:40001 of https://codereview.chromium.org/1906603002/ ) Reason for revert: Speculative revert for failing interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1), starting with https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/11887 Failure: [ RUN ] DragDropTest.DragDropAcrossMultiDisplay Xlib: extension "RANDR" missing on display ":9". [9809:9809:0420/230942:21040728698:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x61600006c980 Xlib: extension "RANDR" missing on display ":9". ../../ash/drag_drop/drag_drop_interactive_uitest.cc:153: Failure Value of: target_view->dropped() Actual: false Expected: true [9809:9809:0420/230942:21040854605:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x61600006c980 [ FAILED ] DragDropTest.DragDropAcrossMultiDisplay (231 ms) Original issue's description: > mus: Fix event transformation in client code. > > Make sure that events are transformed correctly (for high-dpi) in mus > clients. > > BUG=600815 TBR=sky@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600815 Committed: https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f Cr-Commit-Position: refs/heads/master@{#388736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M ui/aura/window_event_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/events/event.cc View 1 chunk +1 line, -8 lines 0 comments Download
M ui/events/event_unittest.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_chromium
Created Revert of mus: Fix event transformation in client code.
4 years, 8 months ago (2016-04-21 10:40:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908913002/1
4 years, 8 months ago (2016-04-21 10:40:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 10:40:43 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:33:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba7639d4d6a012062a0d3c05dea9c222a408b66f
Cr-Commit-Position: refs/heads/master@{#388736}

Powered by Google App Engine
This is Rietveld 408576698