Only call shading code with streams.

Only call shading code with streams.

There are 4 types of meshes that attempt to convert the shading object into
a stream. According to spec (section 8.7.4.1 table 76), the shading object can
be a stream or a dictionary.

All of this shading code assumes it can load the mesh from a stream. The
original code just early exited if it was not a stream. We skip the call
if it is not a stream.

BUG=pdfium:481
Committed: https://pdfium.googlesource.com/pdfium/+/4f70b53efb39e9b9b868d99999582282be57fe50

[dsinclair, 2016-04-21 14:50:41]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-21 14:50:41]

PTAL.

I'll update DEPS once the corpus tests land and will land this with the DEPS
change.

[Tom Sepez, 2016-04-21 16:24:24]

lgtm

https://codereview.chromium.org/1908903003/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp (right):

https://codereview.chromium.org/1908903003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:894: if
(pPattern->m_pShadingObj->IsStream()) {
nit: maybe if (CPFD_Stream* pStream = pPattern->m_pShadingObj->AsStream()) {

https://codereview.chromium.org/1908903003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:896:
ToStream(pPattern->m_pShadingObj), pFuncs,
nit: then you can write
  pStream, pFuncts, 

and save the redundant virtual calls.

[dsinclair, 2016-04-21 16:56:00]

https://codereview.chromium.org/1908903003/diff/1/core/fpdfapi/fpdf_render/fp...
File core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp (right):

https://codereview.chromium.org/1908903003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:894: if
(pPattern->m_pShadingObj->IsStream()) {
On 2016/04/21 16:24:24, Tom Sepez wrote:
> nit: maybe if (CPFD_Stream* pStream = pPattern->m_pShadingObj->AsStream()) {

Done.

https://codereview.chromium.org/1908903003/diff/1/core/fpdfapi/fpdf_render/fp...
core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp:896:
ToStream(pPattern->m_pShadingObj), pFuncs,
On 2016/04/21 16:24:24, Tom Sepez wrote:
> nit: then you can write
>   pStream, pFuncts, 
> 
> and save the redundant virtual calls.

Done.

[dsinclair, 2016-04-21 16:59:50]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-21 16:59:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1908903003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-21 16:59:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908903003/40001

[commit-bot: I haz the power, 2016-04-21 17:54:45]

Description was changed from

==========
Only call shading code with streams.

There are 4 types of meshes that attempt to convert the shading object into
a stream. According to spec (section 8.7.4.1 table 76), the shading object can
be a stream or a dictionary.

All of this shading code assumes it can load the mesh from a stream. The
original code just early exited if it was not a stream. We skip the call
if it is not a stream.

BUG=pdfium:481
==========

to

==========
Only call shading code with streams.

There are 4 types of meshes that attempt to convert the shading object into
a stream. According to spec (section 8.7.4.1 table 76), the shading object can
be a stream or a dictionary.

All of this shading code assumes it can load the mesh from a stream. The
original code just early exited if it was not a stream. We skip the call
if it is not a stream.

BUG=pdfium:481

Committed:
https://pdfium.googlesource.com/pdfium/+/4f70b53efb39e9b9b868d99999582282be57...
==========

[commit-bot: I haz the power, 2016-04-21 17:54:46]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/4f70b53efb39e9b9b868d99999582282be57...