Revert of Replace WTF::Optional the base::Optional implementation.

Revert of Replace WTF::Optional the base::Optional implementation. (patchset #9 id:160001 of https://codereview.chromium.org/1897863006/ )

Reason for revert:
This patch broke Android arm64 Builder on chromium.perf: https://bugs.chromium.org/p/chromium/issues/detail?id=605478

Original issue's description:
> Replace WTF::Optional the base::Optional implementation.
>
> R=jbroman, thakis@chromium.org
> BUG=604860
TBR=jbroman@chromium.org,esprehn@chromium.org,thakis@chromium.org,danakj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604860
Committed: https://crrev.com/7a17ea4bbbeb80ed2091af19d5e90aa40e5e6f9c
Cr-Commit-Position: refs/heads/master@{#388730}

[petrcermak, 2016-04-21 09:58:08]

Created Revert of Replace WTF::Optional the base::Optional implementation.

[commit-bot: I haz the power, 2016-04-21 09:58:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908903002/1

[commit-bot: I haz the power, 2016-04-21 09:58:48]

Committed patchset #1 (id:1)

[Miguel Garcia, 2016-04-21 10:04:34]

On 2016/04/21 09:58:48, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1)

It also broke all non arm32 downstream bots  (like
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/x86-bui...)

[danakj, 2016-04-21 23:45:00]

On Thu, Apr 21, 2016 at 3:04 AM, <miguelg@chromium.org> wrote:

> On 2016/04/21 09:58:48, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1)
>
> It also broke all non arm32 downstream bots (like
>
>
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/x86-bui...
> )
>

How do I test that it doesn't break again before I reland?

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-21 23:45:01]

On Thu, Apr 21, 2016 at 3:04 AM, <miguelg@chromium.org> wrote:

> On 2016/04/21 09:58:48, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1)
>
> It also broke all non arm32 downstream bots (like
>
>
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/x86-bui...
> )
>

How do I test that it doesn't break again before I reland?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[petrcermak, 2016-04-22 09:44:29]

On 2016/04/21 23:45:01, danakj wrote:
> On Thu, Apr 21, 2016 at 3:04 AM, <mailto:miguelg@chromium.org> wrote:
> 
> > On 2016/04/21 09:58:48, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1)
> >
> > It also broke all non arm32 downstream bots (like
> >
> >
>
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/x86-bui...
> > )
> >
> 
> How do I test that it doesn't break again before I reland?
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I'm not a compiler expert, but I would suggest trying it locally on an arm64 and
a x86 device.

[danakj, 2016-04-22 19:02:53]

On Fri, Apr 22, 2016 at 2:44 AM, <petrcermak@chromium.org> wrote:

> On 2016/04/21 23:45:01, danakj wrote:
> > On Thu, Apr 21, 2016 at 3:04 AM, <mailto:miguelg@chromium.org> wrote:
> >
> > > On 2016/04/21 09:58:48, commit-bot: I haz the power wrote:
> > > > Committed patchset #1 (id:1)
> > >
> > > It also broke all non arm32 downstream bots (like
> > >
> > >
> >
>
>
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/x86-bui...
> > > )
> > >
> >
> > How do I test that it doesn't break again before I reland?
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>
> I'm not a compiler expert, but I would suggest trying it locally on an
> arm64 and
> a x86 device.
>

I am unable to repro building with GCC locally, so reland is going in.


>
> https://codereview.chromium.org/1908903002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-22 19:02:54]

On Fri, Apr 22, 2016 at 2:44 AM, <petrcermak@chromium.org> wrote:

> On 2016/04/21 23:45:01, danakj wrote:
> > On Thu, Apr 21, 2016 at 3:04 AM, <mailto:miguelg@chromium.org> wrote:
> >
> > > On 2016/04/21 09:58:48, commit-bot: I haz the power wrote:
> > > > Committed patchset #1 (id:1)
> > >
> > > It also broke all non arm32 downstream bots (like
> > >
> > >
> >
>
>
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/x86-bui...
> > > )
> > >
> >
> > How do I test that it doesn't break again before I reland?
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>
> I'm not a compiler expert, but I would suggest trying it locally on an
> arm64 and
> a x86 device.
>

I am unable to repro building with GCC locally, so reland is going in.


>
> https://codereview.chromium.org/1908903002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-04-22 19:33:00]

Description was changed from

==========
Revert of Replace WTF::Optional the base::Optional implementation. (patchset #9
id:160001 of https://codereview.chromium.org/1897863006/ )

Reason for revert:
This patch broke Android arm64 Builder on chromium.perf:
https://bugs.chromium.org/p/chromium/issues/detail?id=605478

Original issue's description:
> Replace WTF::Optional the base::Optional implementation.
> 
> R=jbroman, thakis@chromium.org
> BUG=604860

TBR=jbroman@chromium.org,esprehn@chromium.org,thakis@chromium.org,danakj@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604860
==========

to

==========
Revert of Replace WTF::Optional the base::Optional implementation. (patchset #9
id:160001 of https://codereview.chromium.org/1897863006/ )

Reason for revert:
This patch broke Android arm64 Builder on chromium.perf:
https://bugs.chromium.org/p/chromium/issues/detail?id=605478

Original issue's description:
> Replace WTF::Optional the base::Optional implementation.
>
> R=jbroman, thakis@chromium.org
> BUG=604860

TBR=jbroman@chromium.org,esprehn@chromium.org,thakis@chromium.org,danakj@chro...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=604860

Committed: https://crrev.com/7a17ea4bbbeb80ed2091af19d5e90aa40e5e6f9c
Cr-Commit-Position: refs/heads/master@{#388730}
==========

[commit-bot: I haz the power, 2016-04-22 19:33:01]

Patchset 1 (id:??) landed as
https://crrev.com/7a17ea4bbbeb80ed2091af19d5e90aa40e5e6f9c
Cr-Commit-Position: refs/heads/master@{#388730}