Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1908893004: SkPathEffect.h: add SK_API where needed (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPathEffect.h: add SK_API where needed motivation: .so fiddle TBR=reed@google.com no api chages, only visibility GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908893004 Committed: https://skia.googlesource.com/skia/+/177f2f69a14281cfc149eb45b633699231a547b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/core/SkPathEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908893004/1
4 years, 8 months ago (2016-04-21 17:37:08 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-21 17:37:09 UTC) #4
hal.canary
PTAL
4 years, 8 months ago (2016-04-21 17:37:22 UTC) #6
jcgregorio
lgtm
4 years, 8 months ago (2016-04-21 17:38:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/8945)
4 years, 8 months ago (2016-04-21 17:38:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908893004/1
4 years, 8 months ago (2016-04-21 17:40:57 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 17:54:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/177f2f69a14281cfc149eb45b633699231a547b3

Powered by Google App Engine
This is Rietveld 408576698