SkTArray: fix invalid reinterpret_casts over non-initialized memory.

SkTArray: fix invalid reinterpret_casts over non-initialized memory.

This should fix 'CFI Linux' buildbot, which is currently horribly broken:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115

BUG=605337
Committed: https://skia.googlesource.com/skia/+/e0c1d285a00e47e1d1584e6a35b95ef2f0d945ff

[krasin, 2016-04-20 23:59:39]

Description was changed from

==========
SkTArray: fix invalid reinterpret_casts over non-initialized memory.

This should fix 'CFI Linux' buildbot, which is currently horribly broken:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115

BUG=605337
==========

to

==========
SkTArray: fix invalid reinterpret_casts over non-initialized memory.

This should fix 'CFI Linux' buildbot, which is currently horribly broken:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115

BUG=605337
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[krasin, 2016-04-21 00:00:12]

krasin@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-04-21 15:00:24]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 15:00:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908763002/1

[bungeman-skia, 2016-04-21 15:00:39]

Description was changed from

==========
SkTArray: fix invalid reinterpret_casts over non-initialized memory.

This should fix 'CFI Linux' buildbot, which is currently horribly broken:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115

BUG=605337
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkTArray: fix invalid reinterpret_casts over non-initialized memory.

This should fix 'CFI Linux' buildbot, which is currently horribly broken:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115

BUG=605337
==========

[bungeman-skia, 2016-04-21 15:01:29]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-04-21 15:32:20]

lgtm (looks very good to me) with nits. I'm going to land this now so that it
rolls into Chromium sooner, I'll fix up the nits myself in a follow up. I would
be interested to know why the previous change set this off (I took a quick look
but didn't see any relevant suppression which should be removed).

https://codereview.chromium.org/1908763002/diff/1/include/private/SkTArray.h
File include/private/SkTArray.h (right):

https://codereview.chromium.org/1908763002/diff/1/include/private/SkTArray.h#...
include/private/SkTArray.h:199: new (newTs + i * sizeof(T)) T;
nit: skia uses four space indents

https://codereview.chromium.org/1908763002/diff/1/include/private/SkTArray.h#...
include/private/SkTArray.h:212: new (newTs + i * sizeof(T)) T(t);
nit: four space

[bungeman-skia, 2016-04-21 15:32:59]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-04-21 15:33:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908763002/1

[commit-bot: I haz the power, 2016-04-21 15:34:02]

Description was changed from

==========
SkTArray: fix invalid reinterpret_casts over non-initialized memory.

This should fix 'CFI Linux' buildbot, which is currently horribly broken:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115

BUG=605337
==========

to

==========
SkTArray: fix invalid reinterpret_casts over non-initialized memory.

This should fix 'CFI Linux' buildbot, which is currently horribly broken:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5115

BUG=605337

Committed:
https://skia.googlesource.com/skia/+/e0c1d285a00e47e1d1584e6a35b95ef2f0d945ff
==========

[commit-bot: I haz the power, 2016-04-21 15:34:03]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e0c1d285a00e47e1d1584e6a35b95ef2f0d945ff