|
|
Created:
4 years, 8 months ago by Dirk Pranke Modified:
4 years, 7 months ago CC:
chromium-reviews, jschuh, Nico, jam, Will Harris, sshruthi1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip remaining CQ Win builders to GN.
This CL flips the remaining CQ builders on tryserver.chromium.win to GN:
- win_chromium_compile_dbg_ng
- win_chromium_rel_ng
and some matching bots on chromium.win:
- Win Builder
- Win Builder (dbg)
and tryserver.chromium.win:
- win_chromium_compile_rel_ng
- win_chromium_dbg_ng
and the affected GPU bots that are also tested by win_chromium_rel_ng:
- GPU Win Builder
- GPU Win Builder (dbg)
R=brucedawson@chromium.org, brettw@chromium.org
BUG=605318
Committed: https://crrev.com/77405408a41233916670d7c4cbf0e18ad451a802
Cr-Commit-Position: refs/heads/master@{#393560}
Patch Set 1 #Patch Set 2 : put win8_chromium_ng back into the CQ for now #Patch Set 3 : merge #Patch Set 4 : merge #Patch Set 5 : re-sort configs #Patch Set 6 : merge again #Patch Set 7 : add copy_compiler_dll as data_deps temporarily #Patch Set 8 : revert data_deps workaround since angle has rolled #Patch Set 9 : patch in nacl fix for testing #Patch Set 10 : patch updated nacl fix #Patch Set 11 : revert nacl fixes since that CL has landed #Messages
Total messages: 40 (19 generated)
The CQ bit was checked by dpranke@chromium.org
The CQ bit was unchecked by dpranke@chromium.org
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/1
Description was changed from ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chormium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and chromium.perf: - Win Builder and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and also removes win8_chromium_ng from the CQ as it is now redundant (apart from the win7/win8 thing). R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ========== to ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and chromium.perf: - Win Builder and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and also removes win8_chromium_ng from the CQ as it is now redundant (apart from the win7/win8 thing). R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ==========
On 2016/04/20 23:10:54, Dirk Pranke wrote: >and also removes win8_chromium_ng from the CQ as it is now >redundant (apart from the win7/win8 thing). what do you mean by this? Will we continue to have some CQ coverage for > Win7? (the win10 trybot is not on the default CQ due to capacity issues).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/04/20 23:25:14, Will Harris wrote: > On 2016/04/20 23:10:54, Dirk Pranke wrote: > >and also removes win8_chromium_ng from the CQ as it is now > >redundant (apart from the win7/win8 thing). > > what do you mean by this? Will we continue to have some CQ coverage for > Win7? > (the win10 trybot is not on the default CQ due to capacity issues). Ah. Hm, looking at this now, I see the win8_chromium_ng bot does run a bunch of tests we might not be running on win7. I would suggest we replace it w/ win10, since we should be freeing up capacity as we flip things over to GN. I can leave it in for the moment while we figure that out.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Description was changed from ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and chromium.perf: - Win Builder and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and also removes win8_chromium_ng from the CQ as it is now redundant (apart from the win7/win8 thing). R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ========== to ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and chromium.perf: - Win Builder and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
The CQ bit was unchecked by dpranke@chromium.org
Hmm ... lots of test failures to look into. I suspect the gpu failures are all related to the way things get packaged into isolates that I'll have to chase w/ kbr@ or someone.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/200001
Description was changed from ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and chromium.perf: - Win Builder and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ========== to ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and the affected GPU bots that are also tested by win_chromium_rel_ng: - GPU Win Builder - GPU Win Builder (dbg) R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ==========
dpranke@chromium.org changed reviewers: + kbr@chromium.org
Okay, I think we can theoretically land this now (all the tests are passing). However, given that we're a week away from the branch, we might not want to land this and leave this in all week if we don't actually want to ship GYP on the branch (because the GYP builder coverage might be a little thin). Thoughts, anyone?
On 2016/05/13 05:03:32, Dirk Pranke wrote: > Okay, I think we can theoretically land this now (all the tests are passing). > > However, given that we're a week away from the branch, we might not want to land > this and leave this in all week if we don't actually want to ship GYP on the > branch (because the GYP builder coverage might be a little thin). > > Thoughts, anyone? though I think it would be useful to land this, say, tomorrow, and leave it in over the weekend to see what if any issues arise, and then revert ...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/05/13 06:10:33, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Land for a few days and then revert sounds like a good idea.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/200001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/200001
Message was sent while issue was closed.
Description was changed from ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and the affected GPU bots that are also tested by win_chromium_rel_ng: - GPU Win Builder - GPU Win Builder (dbg) R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ========== to ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and the affected GPU bots that are also tested by win_chromium_rel_ng: - GPU Win Builder - GPU Win Builder (dbg) R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ==========
Message was sent while issue was closed.
Committed patchset #11 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and the affected GPU bots that are also tested by win_chromium_rel_ng: - GPU Win Builder - GPU Win Builder (dbg) R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 ========== to ========== Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and the affected GPU bots that are also tested by win_chromium_rel_ng: - GPU Win Builder - GPU Win Builder (dbg) R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 Committed: https://crrev.com/77405408a41233916670d7c4cbf0e18ad451a802 Cr-Commit-Position: refs/heads/master@{#393560} ==========
Message was sent while issue was closed.
Patchset 11 (id:??) landed as https://crrev.com/77405408a41233916670d7c4cbf0e18ad451a802 Cr-Commit-Position: refs/heads/master@{#393560}
Message was sent while issue was closed.
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/1981313003/ by dpranke@chromium.org. The reason for reverting is: reverting this until after the branch to maintain coverage .... |