Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1908733002: Flip remaining CQ Win builders to GN. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jschuh, Nico, jam, Will Harris, sshruthi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip remaining CQ Win builders to GN. This CL flips the remaining CQ builders on tryserver.chromium.win to GN: - win_chromium_compile_dbg_ng - win_chromium_rel_ng and some matching bots on chromium.win: - Win Builder - Win Builder (dbg) and tryserver.chromium.win: - win_chromium_compile_rel_ng - win_chromium_dbg_ng and the affected GPU bots that are also tested by win_chromium_rel_ng: - GPU Win Builder - GPU Win Builder (dbg) R=brucedawson@chromium.org, brettw@chromium.org BUG=605318 Committed: https://crrev.com/77405408a41233916670d7c4cbf0e18ad451a802 Cr-Commit-Position: refs/heads/master@{#393560}

Patch Set 1 #

Patch Set 2 : put win8_chromium_ng back into the CQ for now #

Patch Set 3 : merge #

Patch Set 4 : merge #

Patch Set 5 : re-sort configs #

Patch Set 6 : merge again #

Patch Set 7 : add copy_compiler_dll as data_deps temporarily #

Patch Set 8 : revert data_deps workaround since angle has rolled #

Patch Set 9 : patch in nacl fix for testing #

Patch Set 10 : patch updated nacl fix #

Patch Set 11 : revert nacl fixes since that CL has landed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M tools/mb/mb_config.pyl View 1 2 3 4 5 6 7 chunks +24 lines, -16 lines 0 comments Download

Messages

Total messages: 40 (19 generated)
Dirk Pranke
4 years, 8 months ago (2016-04-20 22:53:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/1
4 years, 8 months ago (2016-04-20 22:54:15 UTC) #5
Dirk Pranke
4 years, 8 months ago (2016-04-20 23:10:54 UTC) #7
Will Harris
On 2016/04/20 23:10:54, Dirk Pranke wrote: >and also removes win8_chromium_ng from the CQ as it ...
4 years, 8 months ago (2016-04-20 23:25:14 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/162272)
4 years, 8 months ago (2016-04-20 23:39:27 UTC) #10
Dirk Pranke
On 2016/04/20 23:25:14, Will Harris wrote: > On 2016/04/20 23:10:54, Dirk Pranke wrote: > >and ...
4 years, 8 months ago (2016-04-20 23:43:51 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/20001
4 years, 8 months ago (2016-04-20 23:46:42 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/216023)
4 years, 8 months ago (2016-04-21 00:22:36 UTC) #16
Dirk Pranke
Hmm ... lots of test failures to look into. I suspect the gpu failures are ...
4 years, 8 months ago (2016-04-21 02:40:50 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/200001
4 years, 7 months ago (2016-05-13 05:00:50 UTC) #21
Dirk Pranke
Okay, I think we can theoretically land this now (all the tests are passing). However, ...
4 years, 7 months ago (2016-05-13 05:03:32 UTC) #24
Dirk Pranke
On 2016/05/13 05:03:32, Dirk Pranke wrote: > Okay, I think we can theoretically land this ...
4 years, 7 months ago (2016-05-13 05:04:02 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 06:10:33 UTC) #27
brucedawson
On 2016/05/13 06:10:33, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-13 16:51:28 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/200001
4 years, 7 months ago (2016-05-13 17:06:30 UTC) #30
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-13 17:06:33 UTC) #32
brettw
lgtm
4 years, 7 months ago (2016-05-13 17:09:09 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908733002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908733002/200001
4 years, 7 months ago (2016-05-13 17:11:09 UTC) #35
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 7 months ago (2016-05-13 17:15:18 UTC) #37
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/77405408a41233916670d7c4cbf0e18ad451a802 Cr-Commit-Position: refs/heads/master@{#393560}
4 years, 7 months ago (2016-05-13 17:17:03 UTC) #39
Dirk Pranke
4 years, 7 months ago (2016-05-17 21:42:33 UTC) #40
Message was sent while issue was closed.
A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/1981313003/ by dpranke@chromium.org.

The reason for reverting is: reverting this until after the branch to maintain
coverage ....

Powered by Google App Engine
This is Rietveld 408576698