Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1908613004: Pixel tests are all generated, not .pdf files (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Pixel tests are all generated, not .pdf files The font_size.pdf file should not have been committed as it will be generated at test time from the .in file. Committed: https://pdfium.googlesource.com/pdfium/+/fc397dc66c0a5f02f4bb4558423d4d647f567308

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
D testing/resources/pixel/font_size.pdf View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-21 15:44:09 UTC) #2
Tom Sepez
On 2016/04/21 15:44:09, dsinclair wrote: > PTAL. Stampity stamp LGTM
4 years, 8 months ago (2016-04-21 16:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908613004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908613004/20001
4 years, 8 months ago (2016-04-21 16:44:09 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 17:33:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/fc397dc66c0a5f02f4bb4558423d4d647f56...

Powered by Google App Engine
This is Rietveld 408576698