Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 1908603002: TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails… (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails due to the browser itself throwing an event of type Error that is not an ErrorEvent. BUG= Committed: https://github.com/dart-lang/sdk/commit/b546d0536205dbcf26726e7f74a3185ad941b058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
TBR This fixes html/worker_test/functional which broke due to an unavoidable checked mode check that the ...
4 years, 8 months ago (2016-04-20 17:41:46 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as b546d0536205dbcf26726e7f74a3185ad941b058.
4 years, 8 months ago (2016-04-20 17:42:04 UTC) #4
Alan Knight
4 years, 8 months ago (2016-04-20 17:49:17 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698