test/mjsunit/external-array.js - Issue 19086003: TypedArray.set function should ignore non-array-like arguments instead of throwing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/external-array.js

Issue 19086003: TypedArray.set function should ignore non-array-like arguments instead of throwing. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/external-array.js

diff --git a/test/mjsunit/external-array.js b/test/mjsunit/external-array.js

index deb3c8659dba17982dee3725698aece1bd5322c7..81788d4779e372b665580b34181d8c1bbe16f52b 100644

--- a/test/mjsunit/external-array.js

+++ b/test/mjsunit/external-array.js

@@ -605,8 +605,10 @@ a61.set(a62)

assertArrayPrefix([1, 12], a61)

// Invalid source

-assertThrows(function() { a.set(0) })

-assertThrows(function() { a.set({}) })

+a.set(0); // does not throw

+assertArrayPrefix([1,2,3,4,5,6], a);

+a.set({}); // does not throw

+assertArrayPrefix([1,2,3,4,5,6], a);

// Test arraybuffer.slice

« no previous file with comments | « src/typedarray.js ('k') | test/mjsunit/external-array-no-sse2.js » ('j') | no next file with comments »