Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 19086003: TypedArray.set function should ignore non-array-like arguments instead of throwing. (Closed)

Created:
7 years, 5 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

This does not match ES6 spec but is the behavior in both Firefox and WebKit/Blink. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M src/typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/external-array.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/external-array-no-sse2.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
7 years, 5 months ago (2013-07-12 14:55:10 UTC) #1
Benedikt Meurer
lgtm
7 years, 5 months ago (2013-07-15 05:58:56 UTC) #2
Dmitry Lomov (no reviews)
7 years, 5 months ago (2013-07-15 07:43:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15655 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698