Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1908583002:
Use FakeImeKeyboard when running in mash. (Closed)
|
Created:
4 years, 8 months ago by kylechar Modified:
4 years, 8 months ago CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse FakeImeKeyboard when running in mash.
The OzonePlatform instance doesn't exist in the chrome browser process
when running mash. ImeKeyboardOzone tries to access the instance and
crashes. Always use FakeImeKeyboard with mash until mash IME work is
started and this can be done properly.
BUG=603959
Committed: https://crrev.com/ff1c72875659748df13118ee4446a303b0c9c3a2
Cr-Commit-Position: refs/heads/master@{#388547}
Patch Set 1 #Patch Set 2 : Add TODO. #
Total comments: 2
Patch Set 3 : Moved change. #
Total comments: 2
Patch Set 4 : Add TODO. #Messages
Total messages: 18 (9 generated)
kylechar@chromium.org changed reviewers: + sadrul@chromium.org
https://codereview.chromium.org/1908583002/diff/20001/ui/base/ime/chromeos/im... File ui/base/ime/chromeos/ime_keyboard_ozone.cc (right): https://codereview.chromium.org/1908583002/diff/20001/ui/base/ime/chromeos/im... ui/base/ime/chromeos/ime_keyboard_ozone.cc:90: return new ImeKeyboardOzone(); Can we change the code that creates this? InputMethodManagerImpl() can use chrome::IsRunningInMash() instead of having to define this function in yet another place, and just use FakeImeKeyboard() for now.
Description was changed from ========== Use stub InputController when running in mash. Have ImeKeyboardOzone use a stub InputController when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process with mash so it crashes here. BUG=603959 ========== to ========== Use FakeImeKeyboard when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process when running mash. ImeKeyboardOzone tries to access the instance and crashes. Always use FakeImeKeyboard with mash until mash IME work is started and this can be done properly. BUG=603959 ==========
Description was changed from ========== Use FakeImeKeyboard when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process when running mash. ImeKeyboardOzone tries to access the instance and crashes. Always use FakeImeKeyboard with mash until mash IME work is started and this can be done properly. BUG=603959 ========== to ========== Use FakeImeKeyboard when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process when running mash. ImeKeyboardOzone tries to access the instance and crashes. Always use FakeImeKeyboard with mash until mash IME work is started and this can be done properly. BUG=603959 ==========
kylechar@chromium.org changed reviewers: + oshima@chromium.org
Adding oshima as a reviewer. https://codereview.chromium.org/1908583002/diff/20001/ui/base/ime/chromeos/im... File ui/base/ime/chromeos/ime_keyboard_ozone.cc (right): https://codereview.chromium.org/1908583002/diff/20001/ui/base/ime/chromeos/im... ui/base/ime/chromeos/ime_keyboard_ozone.cc:90: return new ImeKeyboardOzone(); On 2016/04/20 17:51:19, sadrul wrote: > Can we change the code that creates this? InputMethodManagerImpl() can use > chrome::IsRunningInMash() instead of having to define this function in yet > another place, and just use FakeImeKeyboard() for now. Yeah, that makes way more sense.
non-owner lgtm https://codereview.chromium.org/1908583002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/1908583002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/input_method/input_method_manager_impl.cc:860: if (base::SysInfo::IsRunningOnChromeOS() && !chrome::IsRunningInMash()) Add a TODO here noting that we can switch to ImeKeyboard once we have something for InputController, and refer to crbug.com/601981
Patchset #4 (id:60001) has been deleted
https://codereview.chromium.org/1908583002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/1908583002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/input_method/input_method_manager_impl.cc:860: if (base::SysInfo::IsRunningOnChromeOS() && !chrome::IsRunningInMash()) On 2016/04/20 18:18:06, sadrul wrote: > Add a TODO here noting that we can switch to ImeKeyboard once we have something > for InputController, and refer to crbug.com/601981 Done.
lgtm
The CQ bit was checked by kylechar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/1908583002/#ps80001 (title: "Add TODO.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908583002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908583002/80001
Message was sent while issue was closed.
Description was changed from ========== Use FakeImeKeyboard when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process when running mash. ImeKeyboardOzone tries to access the instance and crashes. Always use FakeImeKeyboard with mash until mash IME work is started and this can be done properly. BUG=603959 ========== to ========== Use FakeImeKeyboard when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process when running mash. ImeKeyboardOzone tries to access the instance and crashes. Always use FakeImeKeyboard with mash until mash IME work is started and this can be done properly. BUG=603959 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Use FakeImeKeyboard when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process when running mash. ImeKeyboardOzone tries to access the instance and crashes. Always use FakeImeKeyboard with mash until mash IME work is started and this can be done properly. BUG=603959 ========== to ========== Use FakeImeKeyboard when running in mash. The OzonePlatform instance doesn't exist in the chrome browser process when running mash. ImeKeyboardOzone tries to access the instance and crashes. Always use FakeImeKeyboard with mash until mash IME work is started and this can be done properly. BUG=603959 Committed: https://crrev.com/ff1c72875659748df13118ee4446a303b0c9c3a2 Cr-Commit-Position: refs/heads/master@{#388547} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ff1c72875659748df13118ee4446a303b0c9c3a2 Cr-Commit-Position: refs/heads/master@{#388547} |
