Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1908563002: [chrome.displaySource] Consolidate media pipeline initialization. (Closed)

Created:
4 years, 8 months ago by e_hakkinen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Consolidate media pipeline initialization. This consolidates orchestration of media pipeline initialization steps into one function. That makes it easier to add new steps and to change order of the steps. This does not change the functionality of the media pipeline. BUG=242107 Committed: https://crrev.com/17f325f176e61ef4eb4f8cb47ff387411fb0b084 Cr-Commit-Position: refs/heads/master@{#389045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -30 lines) Patch
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h View 4 chunks +9 lines, -5 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.cc View 3 chunks +57 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
e_hakkinen
PTAL. This should simplify further modification of media pipeline initialisation.
4 years, 8 months ago (2016-04-20 18:34:31 UTC) #2
Mikhail
lgtm
4 years, 8 months ago (2016-04-20 19:00:42 UTC) #3
asargent_no_longer_on_chrome
lgtm
4 years, 8 months ago (2016-04-21 19:55:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908563002/1
4 years, 8 months ago (2016-04-22 06:01:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 06:38:25 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:45:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17f325f176e61ef4eb4f8cb47ff387411fb0b084
Cr-Commit-Position: refs/heads/master@{#389045}

Powered by Google App Engine
This is Rietveld 408576698