Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1908543002: DNS: Retain stale entries in HostCache and return when requested (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and rearrange .h slightly per sleevi's suggestion. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« net/dns/host_cache_unittest.cc ('K') | « net/log/net_log_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index bb7f8d9bdac504a7dc28fb9edd0d9fcd7fcb9ea7..239ae799abe0dabca97eb2193e23caa89a5bd2cf 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -8797,6 +8797,146 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="DNS.HostCache.ClearStale.ExpiredBy" units="ms">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When clearing a stale (expired or old-network) DNS entry from the host
+ cache, (when the whole cache is cleared), how long past the expiration time
+ it is.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.ClearStale.NetworkChanges" units="changes">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When clearing a stale (expired or old-network) DNS entry from the host cache
+ (when the whole cache is cleared), how many network changes happened between
+ setting and clearing it.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.ClearStale.StaleHits" units="hits">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When clearing a stale (expired or old-network) DNS entry from the host cache
+ (when the whole cache is cleared), how many hits it received while stale.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.ClearValid.ValidFor" units="ms">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When clearing a valid DNS entry from the host cache (when the whole cache is
+ cleared), for how much longer it would have remained valid.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.Erase" enum="DNS.HostCache.EraseReason">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>The reason for erasing a DNS entry from the host cache.</summary>
+</histogram>
+
+<histogram name="DNS.HostCache.EvictStale.ExpiredBy" units="ms">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When evicting a stale (expired or old-network) DNS entry from the host
+ cache, how long past the expiration time it is.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.EvictStale.NetworkChanges" units="changes">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When evicting a stale (expired or old-network) DNS entry from the host
+ cache, how many network changes happened between setting and evicting it.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.EvictStale.StaleHits" units="hits">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When evicting a stale (expired or old-network) DNS entry from the host
+ cache, how many hits it received while stale.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.EvictValid.ValidFor" units="ms">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When evicting a valid DNS entry from the host cache, for how much longer it
+ would have remained valid.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.Lookup" enum="DNS.HostCache.LookupOutcome">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>The outcome of looking up a DNS entry in the host cache.</summary>
+</histogram>
+
+<histogram name="DNS.HostCache.LookupStale.ExpiredBy" units="ms">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When looking up a stale DNS entry in the host cache, how long past the
+ expiration time it is.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.LookupStale.NetworkChanges" units="changes">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When looking up a stale DNS entry in the host cache, how many network
+ changes happened between setting it and looking it up.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.LookupStale.StaleHits" units="hits">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When looking up a stale DNS entry in the host cache, how many hits
+ (including this one) it received while stale.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.Set" enum="DNS.HostCache.SetOutcome">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>The outcome of setting a DNS entry in the host cache.</summary>
+</histogram>
+
+<histogram name="DNS.HostCache.UpdateStale.AddressListDelta"
+ enum="DNS.AddressListDeltaType">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When updating a stale (expired or old-network) DNS entry in the host cache,
+ and both results are successful, how the address list differs between the
+ old and new entries.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.UpdateStale.ExpiredBy" units="ms">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When updating a stale (expired or old-network) DNS entry in the host cache,
+ how long past the expiration time the old entry was.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.UpdateStale.NetworkChanges" units="changes">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ When updating a stale (expired or old-nework) DNS entry in the host cache,
+ how many network changes happened between setting the old entry and setting
+ the new entry.
+ </summary>
+</histogram>
+
+<histogram name="DNS.HostCache.UpdateStale.StaleHits" units="hits">
+ <owner>juliatuttle@chromium.org</owner>
+ <summary>
+ The number of hits received to an updated stale DNS entry in the host cache
+ while it was stale.
+ </summary>
+</histogram>
+
<histogram name="DNS.IndependentFailedNavigation" units="ms">
<owner>juliatuttle@chromium.org</owner>
<summary>
@@ -66549,6 +66689,32 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="2132270559" label="libsvn_tsvn32.dll"/>
</enum>
+<enum name="DNS.AddressListDeltaType" type="int">
+ <int value="0" label="Same addresses in the same order"/>
+ <int value="1" label="Same addresses in a different order"/>
+ <int value="2" label="Some but not all addresses in common"/>
+ <int value="3" label="No addresses in common"/>
+</enum>
+
+<enum name="DNS.HostCache.EraseReason" type="int">
+ <int value="0" label="Entry evicted"/>
+ <int value="1" label="Cache cleared"/>
+ <int value="2" label="Cache destroyed"/>
+</enum>
+
+<enum name="DNS.HostCache.LookupOutcome" type="int">
+ <int value="0" label="Miss (absent)"/>
+ <int value="1" label="Miss (stale when not requested)"/>
+ <int value="2" label="Hit (valid)"/>
+ <int value="3" label="Hit (stale when requested)"/>
+</enum>
+
+<enum name="DNS.HostCache.SetOutcome" type="int">
+ <int value="0" label="Inserted new entry"/>
+ <int value="1" label="Updated valid entry"/>
+ <int value="2" label="Updated stale entry"/>
+</enum>
+
<enum name="DNSEmptyAddressListAndNoError" type="int">
<int value="0" label="Error reported or Address List is not empty"/>
<int value="1" label="Success reported but Address List is empty"/>
@@ -90143,6 +90309,15 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Platform.DiskUsage.LeastUsedAccountDays"/>
</histogram_suffixes>
+<histogram_suffixes name="DNS.HostCache.UpdateStale.AddressListDeltaType">
+ <suffix name="Identical" label="Same addresses, in the same order."/>
+ <suffix name="Reordered" label="Same addresses, in a different order."/>
+ <suffix name="Overlap" label="Some same addreses, some different."/>
+ <suffix name="Disjoint" label="All different addresses."/>
+ <affected-histogram name="DNS.HostCache.UpdateStale.ExpiredBy"/>
+ <affected-histogram name="DNS.HostCache.UpdateStale.NetworkChanges"/>
+</histogram_suffixes>
+
<histogram_suffixes name="DnsImpact2">
<suffix name="disabled_prefetch"
label="DNS pre-resolving is disabled in these clients"/>
« net/dns/host_cache_unittest.cc ('K') | « net/log/net_log_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698