Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 89c90fb8acaf1e0471ed57aa0eb49d46b4cc2526..d73c4b9d512b7ccc918e623fd3270cae15821999 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -8724,6 +8724,145 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="DNS.HostCacheClearStaleExpiredBy" units="ms"> |
|
Alexei Svitkine (slow)
2016/04/27 15:45:33
Nit: I suggest adding an intermediate . to make th
Julia Tuttle
2016/04/27 21:36:22
Done.
|
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When clearing a stale (expired or old-network) DNS entry from the host |
| + cache, (when the whole cache is cleared), how long past the expiration time |
| + it is. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheClearStaleHits"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When clearing a stale (expired or old-network) DNS entry from the host cache |
| + (when the whole cache is cleared), how many hits it received while stale. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheClearStaleNetworkChanges"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When clearing a stale (expired or old-network) DNS entry from the host cache |
| + (when the whole cache is cleared), how many network changes happened between |
| + setting and clearing it. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheClearValidFor" units="ms"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When clearing a valid DNS entry from the host cache (when the whole cache is |
| + cleared), for how much longer it would have remained valid. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheErase" enum="DNS.HostCacheEraseReason"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary>The reason for erasing a DNS entry from the host cache.</summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheEvictStaleExpiredBy" units="ms"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When evicting a stale (expired or old-network) DNS entry from the host |
| + cache, how long past the expiration time it is. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheEvictStaleHits"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When evicting a stale (expired or old-network) DNS entry from the host |
| + cache, how many hits it received while stale. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheEvictStaleNetworkChanges"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When evicting a stale (expired or old-network) DNS entry from the host |
| + cache, how many network changes happened between setting and evicting it. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheEvictValidFor" units="ms"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When evicting a valid DNS entry from the host cache, for how much longer it |
| + would have remained valid. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheLookup" enum="DNS.HostCacheLookupOutcome"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary>The outcome of looking up a DNS entry in the host cache.</summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheLookupStaleExpiredBy" units="ms"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When looking up a stale DNS entry in the host cache, how long past the |
| + expiration time it is. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheLookupStaleHit"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When looking up a stale DNS entry in the host cache, how many hits |
| + (including this one) it received while stale. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheLookupStaleNetworkChanges"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When looking up a stale DNS entry in the host cache, how many network |
| + changes happened between setting it and looking it up. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheSet" enum="DNS.HostCacheSetOutcome"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary>The outcome of setting a DNS entry in the host cache.</summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheUpdateStaleDelta" enum="DNS.AddressListDeltaType"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When updating a stale (expired or old-network) DNS entry in the host cache, |
| + and both results are successful, how the address list differs between the |
| + old and new entries. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheUpdateStaleExpiredBy" units="ms"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When updating a stale (expired or old-network) DNS entry in the host cache, |
| + how long past the expiration time the old entry was. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheUpdateStaleHits"> |
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + The number of hits received to an updated stale DNS entry in the host cache |
| + while it was stale. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DNS.HostCacheUpdateStaleNetworkChanges"> |
|
Alexei Svitkine (slow)
2016/04/27 15:45:33
Nit: Add units=. Same everywhere else where you do
Julia Tuttle
2016/04/27 21:36:22
Done.
|
| + <owner>juliatuttle@chromium.org</owner> |
| + <summary> |
| + When updating a stale (expired or old-nework) DNS entry in the host cache, |
| + how many network changes happened between setting the old entry and setting |
| + the new entry. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="DNS.IndependentFailedNavigation" units="ms"> |
| <owner>juliatuttle@chromium.org</owner> |
| <summary> |
| @@ -65850,6 +65989,32 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="2132270559" label="libsvn_tsvn32.dll"/> |
| </enum> |
| +<enum name="DNS.AddressListDeltaType" type="int"> |
| + <int value="0" label="Same addresses in the same order"/> |
| + <int value="1" label="Same addresses in a different order"/> |
| + <int value="2" label="Some but not all addresses in common"/> |
| + <int value="3" label="No addresses in common"/> |
| +</enum> |
| + |
| +<enum name="DNS.HostCacheEraseReason" type="int"> |
| + <int value="0" label="Entry evicted"/> |
| + <int value="1" label="Cache cleared"/> |
| + <int value="2" label="Cache destroyed"/> |
| +</enum> |
| + |
| +<enum name="DNS.HostCacheLookupOutcome" type="int"> |
| + <int value="0" label="Miss (absent)"/> |
| + <int value="1" label="Miss (stale when not requested)"/> |
| + <int value="2" label="Hit (valid)"/> |
| + <int value="3" label="Hit (stale when requested)"/> |
| +</enum> |
| + |
| +<enum name="DNS.HostCacheSetOutcome" type="int"> |
| + <int value="0" label="Inserted new entry"/> |
| + <int value="1" label="Updated valid entry"/> |
| + <int value="2" label="Updated stale entry"/> |
| +</enum> |
| + |
| <enum name="DNSEmptyAddressListAndNoError" type="int"> |
| <int value="0" label="Error reported or Address List is not empty"/> |
| <int value="1" label="Success reported but Address List is empty"/> |
| @@ -89317,6 +89482,15 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <affected-histogram name="Platform.DiskUsage.LeastUsedAccountDays"/> |
| </histogram_suffixes> |
| +<histogram_suffixes name="DNS.HostCacheUpdateStaleDeltaType"> |
|
Alexei Svitkine (slow)
2016/04/27 15:45:33
Nit: Up to you, but I find using . as separator to
Julia Tuttle
2016/04/27 21:36:22
I prefer . for the general hierarchy but _ for the
|
| + <affected-histogram name="DNS.HostCacheUpdateStaleExpiredBy"/> |
| + <suffix name="Identical" label="Same addresses, in the same order."/> |
| + <suffix name="Reordered" label="Same addresses, in a different order."/> |
| + <suffix name="Overlap" label="Some same addreses, some different."/> |
| + <suffix name="Disjoint" label="All different addresses."/> |
| + <affected-histogram name="DNS.HostCacheUpdateStaleNetworkChanges"/> |
| +</histogram_suffixes> |
| + |
| <histogram_suffixes name="DnsImpact2"> |
| <suffix name="disabled_prefetch" |
| label="DNS pre-resolving is disabled in these clients"/> |