Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1908533002: Remove superfluous "*-expected.txt" files in LayoutTests/fast (Closed)

Created:
4 years, 8 months ago by Srirama
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove superfluous "*-expected.txt" files in LayoutTests/fast There are "*-expected.txt" files for some of the testharness.js based tests in LayoutTests/fast/dom folder. Removing these files as they are not necessary. Committed: https://crrev.com/07a61746ca99c26c35e1d08b529890fd704c249c Cr-Commit-Position: refs/heads/master@{#388690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -79 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/font-face-unicode-range-ligatures.html View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/font-face-unicode-range-ligatures-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/file-reader-result-twice.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/files/file-reader-result-twice-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/media/mq-color-index-01.html View 2 chunks +1 line, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/media/mq-color-index-01-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/media/mq-viewport-units.html View 2 chunks +1 line, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/media/mq-viewport-units-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-different-writing-modes-left.html View 2 chunks +5 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-different-writing-modes-left-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/text-range-bounds.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/text-range-bounds-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Srirama
PTAL. Removed all the unnecessary "*-expected.txt" files in LayoutTests/fast folder.
4 years, 8 months ago (2016-04-20 15:40:15 UTC) #4
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-20 21:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908533002/1
4 years, 8 months ago (2016-04-21 03:10:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 04:12:09 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:31:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07a61746ca99c26c35e1d08b529890fd704c249c
Cr-Commit-Position: refs/heads/master@{#388690}

Powered by Google App Engine
This is Rietveld 408576698