Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: test/cctest/test-microtask-delivery.cc

Issue 190853007: Revert "Enable Object.observe by default" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 18 matching lines...) Expand all
29 29
30 #include "cctest.h" 30 #include "cctest.h"
31 31
32 using namespace v8; 32 using namespace v8;
33 namespace i = v8::internal; 33 namespace i = v8::internal;
34 34
35 namespace { 35 namespace {
36 class HarmonyIsolate { 36 class HarmonyIsolate {
37 public: 37 public:
38 HarmonyIsolate() { 38 HarmonyIsolate() {
39 i::FLAG_harmony_observation = true;
39 i::FLAG_harmony_promises = true; 40 i::FLAG_harmony_promises = true;
40 isolate_ = Isolate::New(); 41 isolate_ = Isolate::New();
41 isolate_->Enter(); 42 isolate_->Enter();
42 } 43 }
43 44
44 ~HarmonyIsolate() { 45 ~HarmonyIsolate() {
45 isolate_->Exit(); 46 isolate_->Exit();
46 isolate_->Dispose(); 47 isolate_->Dispose();
47 } 48 }
48 49
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 "foo.id++;"); 128 "foo.id++;");
128 } 129 }
129 { 130 {
130 LocalContext context4(isolate.GetIsolate()); 131 LocalContext context4(isolate.GetIsolate());
131 context4->Global()->Set(String::NewFromUtf8(isolate.GetIsolate(), "obj"), 132 context4->Global()->Set(String::NewFromUtf8(isolate.GetIsolate(), "obj"),
132 obj); 133 obj);
133 V8::RunMicrotasks(isolate.GetIsolate()); 134 V8::RunMicrotasks(isolate.GetIsolate());
134 CHECK_EQ(2, CompileRun("obj.calls")->Int32Value()); 135 CHECK_EQ(2, CompileRun("obj.calls")->Int32Value());
135 } 136 }
136 } 137 }
OLDNEW
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698