Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Unified Diff: content/public/app/content_main_runner.h

Issue 190853004: Convert ContentMain to take a struct instead of parameters that vary depending on the platform. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/app/content_main_runner.h
===================================================================
--- content/public/app/content_main_runner.h (revision 255697)
+++ content/public/app/content_main_runner.h (working copy)
@@ -5,22 +5,9 @@
#ifndef CONTENT_PUBLIC_APP_CONTENT_MAIN_RUNNER_H_
#define CONTENT_PUBLIC_APP_CONTENT_MAIN_RUNNER_H_
-#include <string>
-
-#include "build/build_config.h"
-
-#if defined(OS_WIN)
-#include <windows.h>
-#endif
-
-namespace sandbox {
-struct SandboxInterfaceInfo;
-}
-
namespace content {
+struct ContentMainParams;
-class ContentMainDelegate;
-
// This class is responsible for content initialization, running and shutdown.
class ContentMainRunner {
public:
@@ -30,19 +17,7 @@
static ContentMainRunner* Create();
// Initialize all necessary content state.
-#if defined(OS_WIN)
- // The |sandbox_info| and |delegate| objects must outlive this class.
- // |sandbox_info| should be initialized using InitializeSandboxInfo from
- // content_main_win.h.
- virtual int Initialize(HINSTANCE instance,
- sandbox::SandboxInterfaceInfo* sandbox_info,
- ContentMainDelegate* delegate) = 0;
-#else
- // The |delegate| object must outlive this class.
- virtual int Initialize(int argc,
- const char** argv,
- ContentMainDelegate* delegate) = 0;
-#endif
+ virtual int Initialize(ContentMainParams* params) = 0;
// Perform the default run logic.
virtual int Run() = 0;

Powered by Google App Engine
This is Rietveld 408576698