Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: content/app/content_main.cc

Issue 190853004: Convert ContentMain to take a struct instead of parameters that vary depending on the platform. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/app/content_main.cc
===================================================================
--- content/app/content_main.cc (revision 255697)
+++ content/app/content_main.cc (working copy)
@@ -9,26 +9,10 @@
namespace content {
-#if defined(OS_WIN)
-int ContentMain(HINSTANCE instance,
- sandbox::SandboxInterfaceInfo* sandbox_info,
- ContentMainDelegate* delegate) {
-#else
-int ContentMain(int argc,
- const char** argv,
- ContentMainDelegate* delegate) {
-#endif // OS_WIN
-
+int ContentMain(ContentMainParams* params) {
sky 2014/03/07 23:14:22 Is it possible to make the various mains take a co
jam 2014/03/07 23:29:12 Done.
scoped_ptr<ContentMainRunner> main_runner(ContentMainRunner::Create());
- int exit_code;
-
-#if defined(OS_WIN)
- exit_code = main_runner->Initialize(instance, sandbox_info, delegate);
-#else
- exit_code = main_runner->Initialize(argc, argv, delegate);
-#endif // OS_WIN
-
+ int exit_code = main_runner->Initialize(params);
if (exit_code >= 0)
return exit_code;

Powered by Google App Engine
This is Rietveld 408576698