Issue 190853004: Convert ContentMain to take a struct instead of parameters that vary depending on the platform.

Issue 190853004: Convert ContentMain to take a struct instead of parameters that vary depending on the platform. (Closed)

Created:
6 years, 9 months ago by jam

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, ben+ash_chromium.org, kalyank, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert ContentMain to take a struct instead of parameters that vary depending on the platform. This helps reduce ifdef mess, and makes it easier to add extra optional parameters. In a followup cl, I'll move the ui_task parameter from MainFunctionParams to ContentMainParams. BUG=350550 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255866

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : review comments #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : sync #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -144 lines)			Patch
M	apps/shell/app/shell_main.cc	View	1 2 3 4 5 6	1 chunk	+13 lines, -10 lines	0 comments	Download
M	ash/shell/shell_main.cc	View	1 2 3 4 5 6	1 chunk	+14 lines, -7 lines	0 comments	Download
M	chrome/app/chrome_main.cc	View	1 2 3 4 5 6	1 chunk	+19 lines, -7 lines	0 comments	Download
M	content/app/android/content_main.cc	View	1 2 3 4 5 6	3 chunks	+4 lines, -6 lines	0 comments	Download
M	content/app/content_main.cc	View	1 2 3 4 5 6	1 chunk	+2 lines, -18 lines	0 comments	Download
M	content/app/content_main_runner.cc	View	1 2 3 4 5 6	8 chunks	+30 lines, -28 lines	0 comments	Download
M	content/public/app/content_main.h	View	1 2 3 4 5 6	3 chunks	+34 lines, -15 lines	0 comments	Download
M	content/public/app/content_main_runner.h	View	1 2 3 4 5 6	2 chunks	+2 lines, -27 lines	0 comments	Download
M	content/public/common/main_function_params.h	View	1 2 3 4 5 6	2 chunks	+6 lines, -2 lines	0 comments	Download
M	content/public/test/test_launcher.cc	View	1 2 3 4 5 6	2 chunks	+15 lines, -14 lines	0 comments	Download
M	content/shell/app/shell_content_main.cc	View	1 2 3 4 5 6	1 chunk	+4 lines, -1 line	0 comments	Download
M	content/shell/app/shell_main.cc	View	1 2 3 4 5 6	2 chunks	+9 lines, -2 lines	0 comments	Download
M	ui/views/examples/content_client/examples_main.cc	View	1 2 3 4	1 chunk	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/190853004/diff/1/content/app/content_main.cc File content/app/content_main.cc (right): https://codereview.chromium.org/190853004/diff/1/content/app/content_main.cc#newcode12 content/app/content_main.cc:12: int ContentMain(ContentMainParams* params) { Is it possible to ...

6 years, 9 months ago (2014-03-07 23:14:21 UTC) #2

jam

6 years, 9 months ago (2014-03-07 23:29:11 UTC) #3

https://codereview.chromium.org/190853004/diff/1/content/app/content_main.cc
File content/app/content_main.cc (right):

https://codereview.chromium.org/190853004/diff/1/content/app/content_main.cc#...
content/app/content_main.cc:12: int ContentMain(ContentMainParams* params) {
On 2014/03/07 23:14:22, sky wrote:
> Is it possible to make the various mains take a const ContentMainParams& ?

Done.

https://codereview.chromium.org/190853004/diff/1/content/public/app/content_m...
File content/public/app/content_main.h (right):

https://codereview.chromium.org/190853004/diff/1/content/public/app/content_m...
content/public/app/content_main.h:46: int  argc;
On 2014/03/07 23:14:22, sky wrote:
> nit: I think you have 2 spaces here.

Done.

Expand Messages | Collapse Messages