bluetooth: Make IsGattServicesDiscoveryComplete virtual

bluetooth: Make IsGattServicesDiscoveryComplete virtual

Also makes SetServicesDiscoveryComplete virtual. This way we can have
different implementations of these functions.

Also modifies mock adapters to specify what this now virtual functions
return.

BUG=599472
Committed: https://crrev.com/3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826
Cr-Commit-Position: refs/heads/master@{#388563}

[ortuno, 2016-04-20 15:14:07]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-04-20 15:14:08]

scheib: PTAL

[scheib, 2016-04-20 17:50:35]

LGTM with a code ordering change request:

https://codereview.chromium.org/1908523002/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1908523002/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:459:
if (services.size() > 0) {
This request of mine will make the code diff larger -- but will make the code
easier to read. Please make the code ordering follow the chronological order.
The first response of false and adding services should be before the return
true. That way the comment that describes what happens and the code read
chronologically. aka make this
  if (services.size() == 0)
  ...
  else return true.

[ortuno, 2016-04-20 18:03:19]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-04-20 18:03:19]

Thanks!

https://codereview.chromium.org/1908523002/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1908523002/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:459:
if (services.size() > 0) {
On 2016/04/20 at 17:50:35, scheib wrote:
> This request of mine will make the code diff larger -- but will make the code
easier to read. Please make the code ordering follow the chronological order.
The first response of false and adding services should be before the return
true. That way the comment that describes what happens and the code read
chronologically. aka make this
>   if (services.size() == 0)
>   ...
>   else return true.

Done.

[ortuno, 2016-04-20 18:03:20]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1908523002/#ps20001
(title: "Address scheib's comments")

[commit-bot: I haz the power, 2016-04-20 18:03:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908523002/20001

[commit-bot: I haz the power, 2016-04-20 20:08:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:25:55]

Description was changed from

==========
bluetooth: Make IsGattServicesDiscoveryComplete virtual

Also makes SetServicesDiscoveryComplete virtual. This way we can have
different implementations of these functions.

Also modifies mock adapters to specify what this now virtual functions
return.

BUG=599472
==========

to

==========
bluetooth: Make IsGattServicesDiscoveryComplete virtual

Also makes SetServicesDiscoveryComplete virtual. This way we can have
different implementations of these functions.

Also modifies mock adapters to specify what this now virtual functions
return.

BUG=599472

Committed: https://crrev.com/3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826
Cr-Commit-Position: refs/heads/master@{#388563}
==========

[commit-bot: I haz the power, 2016-04-22 19:25:56]

Patchset 2 (id:??) landed as
https://crrev.com/3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826
Cr-Commit-Position: refs/heads/master@{#388563}