Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/android/loading/cloud/backend/google_storage_accessor.py

Issue 1908483002: tools/android/loading Loading trace database improvements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor cleanup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/loading/cloud/backend/google_storage_accessor.py
diff --git a/tools/android/loading/cloud/backend/google_storage_accessor.py b/tools/android/loading/cloud/backend/google_storage_accessor.py
index 86e238e8e2f0560c1ee28804a3ebb5423d6649f6..ded3fe83a3d1072e540093344d82fffb60db3f86 100644
--- a/tools/android/loading/cloud/backend/google_storage_accessor.py
+++ b/tools/android/loading/cloud/backend/google_storage_accessor.py
@@ -2,7 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-from gcloud import storage
+import gcloud.exceptions
+import gcloud.storage
class GoogleStorageAccessor(object):
@@ -18,12 +19,26 @@ class GoogleStorageAccessor(object):
def _GetStorageClient(self):
"""Returns the storage client associated with the project"""
- return storage.Client(project = self._project_name,
- credentials = self._credentials)
+ return gcloud.storage.Client(project = self._project_name,
+ credentials = self._credentials)
def _GetStorageBucket(self, storage_client):
return storage_client.get_bucket(self._bucket_name)
+ def DownloadAsString(self, remote_filename):
+ """Returns the content of a remote file as a string, or None if the file
+ does not exist.
+ """
+ client = self._GetStorageClient()
+ bucket = self._GetStorageBucket(client)
+ blob = bucket.get_blob(remote_filename)
+ if not blob:
+ return None
+ try:
+ return blob.download_as_string()
+ except gcloud.exceptions.NotFound:
+ return None
+
def UploadFile(self, filename_src, filename_dest):
"""Uploads a file to Google Cloud Storage
« no previous file with comments | « tools/android/loading/cloud/backend/README.md ('k') | tools/android/loading/cloud/backend/startup-script.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698