third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html - Issue 1908463002: Modernize fast/hidpi layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html

Issue 1908463002: Modernize fast/hidpi layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/hidpi/broken-image-with-size-hidpi.html ('K') | « third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs.html ('k') | third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-nomodifier.html » ('j') | third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-only-src-attribute.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html

diff --git a/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html b/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html

index d207d7a32303c7efeb23194be3769f26dda1286e..85085fcc4b369b2ac2625ff5216040da96abc20b 100644

--- a/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html

+++ b/third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html

@@ -1,5 +1,4 @@

-<html>

-<head>

+<!DOCTYPE html>

@@ -11,11 +10,6 @@

shouldBeTrue('document.getElementById("foo").clientWidth==200');

}, false);

</script>

-</head>

-<body id="body">

- <div>This test passes if the img tag below is a green square regardless of the scale factor. It ensures that invalid inputs are

+<div>This test passes if the img tag below is a green square regardless of the scale factor. It ensures that invalid inputs are

ignored and well-formed images are chosen regardless of their qualifiers, once they are the only candidate left</div>

- <img id="foo" src="" srcset="1x,, , x ,2x , foo.jpg, 3x, bar.jpg 4x 100h, foo.jpg 5, bar.jpg dx, resources/green-400-px-square.png 2x ,"></img>

-</body>

-</html>

+<img id="foo" src="" srcset="1x,, , x ,2x , foo.jpg, 3x, bar.jpg 4x 100h, foo.jpg 5, bar.jpg dx, resources/green-400-px-square.png 2x ,"></img>

Yoav Weiss 2016/04/20 13:36:13 we can drop "</img>"

davve 2016/04/21 08:58:01 Done.