Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1908443003: Set site engagement timestamps to privacy-respectful values when history is cleared. (Closed)

Created:
4 years, 8 months ago by dominickn
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Set site engagement timestamps to privacy-respectful values when history is cleared. The site engagement service stores last updated and last shortcut launch timestamps per origin. When history is cleared, the former is set to the time of history clearing and the latter is not changed. This CL sets both timestamps to the time of the most recent remaining visit in history for that origin once history clearing is completed. The last shortcut launch time is only set if it was non-null prior to the history being cleared. A slight change to the history service query (adding the last visited date to the data returned) is necessary to enable this change. More comprehensive testing of the history expiry mechanism are added to ensure correctness. BUG=604284 Review URL: https://codereview.chromium.org/1901563002 Cr-Commit-Position: refs/heads/master@{#388321} (cherry picked from commit 3d900e9e2c2dc6cda11c94aea9848181a9b4ffd1) Committed: https://chromium.googlesource.com/chromium/src/+/860a9e7ace12d0376f6698560c7a4a17c4f8cf04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -97 lines) Patch
M chrome/browser/engagement/site_engagement_service.h View 3 chunks +24 lines, -4 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service.cc View 6 chunks +80 lines, -32 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service_unittest.cc View 5 chunks +79 lines, -16 lines 0 comments Download
M components/history/core/browser/history_backend.h View 2 chunks +6 lines, -5 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 1 chunk +12 lines, -7 lines 0 comments Download
M components/history/core/browser/history_backend_unittest.cc View 1 chunk +35 lines, -19 lines 0 comments Download
M components/history/core/browser/history_service.h View 2 chunks +9 lines, -6 lines 0 comments Download
M components/history/core/browser/history_service.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M components/history/core/browser/history_types.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
4 years, 8 months ago (2016-04-21 06:09:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
860a9e7ace12d0376f6698560c7a4a17c4f8cf04.

Powered by Google App Engine
This is Rietveld 408576698