Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1	21.5ms -> 17.8ms	0.83x
                    desk_mapsvg.skp_1	7.49ms -> 6.18ms	0.82x
Others results are more volatile.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908433002

Committed: https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22

[Kimmo Kinnunen, 2016-04-20 09:26:16]

Description was changed from

==========
Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1	21.5ms -> 17.8ms	0.83x
                    desk_mapsvg.skp_1	7.49ms -> 6.18ms	0.82x
Others results are more volatile.
==========

to

==========
Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1	21.5ms -> 17.8ms	0.83x
                    desk_mapsvg.skp_1	7.49ms -> 6.18ms	0.82x
Others results are more volatile.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-04-20 09:26:30]

The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 09:26:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908433002/1

[commit-bot: I haz the power, 2016-04-20 09:26:40]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-04-20 15:26 UTC

[Kimmo Kinnunen, 2016-04-20 09:27:15]

kkinnunen@nvidia.com changed reviewers:
+ joshualitt@chromium.org

[commit-bot: I haz the power, 2016-04-20 09:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 09:29:29]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[Kimmo Kinnunen, 2016-04-20 10:28:40]

The CQ bit was checked by kkinnunen@nvidia.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 10:28:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908433002/20001

[Kimmo Kinnunen, 2016-04-22 07:54:09]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-04-22 13:20:39]

lgtm, minor stuff inline

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/GrPath.h
File src/gpu/GrPath.h (right):

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/GrPath.h...
src/gpu/GrPath.h:40: /** Returns true if a path can be drawn in the same draw
paths operation as the other
We we usually write this style of comments as

/**
 * First line begins here.

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/gl/GrGLP...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/gl/GrGLP...
src/gpu/gl/GrGLPathRendering.cpp:196: if (count == 0) {
can just say !count if you prefer, not required

[Kimmo Kinnunen, 2016-04-25 08:36:00]

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/GrPath.h
File src/gpu/GrPath.h (right):

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/GrPath.h...
src/gpu/GrPath.h:40: /** Returns true if a path can be drawn in the same draw
paths operation as the other
On 2016/04/22 13:20:38, bsalomon wrote:
> We we usually write this style of comments as
> 
> /**
>  * First line begins here.

Done.

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/gl/GrGLP...
File src/gpu/gl/GrGLPathRendering.cpp (right):

https://chromiumcodereview.appspot.com/1908433002/diff/60001/src/gpu/gl/GrGLP...
src/gpu/gl/GrGLPathRendering.cpp:196: if (count == 0) {
On 2016/04/22 13:20:39, bsalomon wrote:
> can just say !count if you prefer, not required

Done.

[Kimmo Kinnunen, 2016-04-25 09:02:30]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2016-04-25 09:02:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1908433002/#ps80001
(title: "address review comments")

[commit-bot: I haz the power, 2016-04-25 09:02:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908433002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908433002/80001

[commit-bot: I haz the power, 2016-04-25 09:16:13]

Description was changed from

==========
Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1	21.5ms -> 17.8ms	0.83x
                    desk_mapsvg.skp_1	7.49ms -> 6.18ms	0.82x
Others results are more volatile.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1	21.5ms -> 17.8ms	0.83x
                    desk_mapsvg.skp_1	7.49ms -> 6.18ms	0.82x
Others results are more volatile.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22
==========

[commit-bot: I haz the power, 2016-04-25 09:16:14]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22

[stephana, 2016-04-25 14:01:06]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1919843002/ by stephana@google.com.

The reason for reverting is: This causes what looks like significantly wrong
results. Here is an example:

https://gold.skia.org/diff?test=stroke-fill&left=cb47dc2cabbad7d146aedaac199e...

.

[Kimmo Kinnunen, 2016-05-02 08:22:05]

Description was changed from

==========
Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1	21.5ms -> 17.8ms	0.83x
                    desk_mapsvg.skp_1	7.49ms -> 6.18ms	0.82x
Others results are more volatile.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22
==========

to

==========
Batch multiple single NVPR draw paths to instanced draws

Batch multiple single NVPR draw paths to instanced draws.
A draw path batch can be combined to other batch if the
batches do not overlap and have same draw characteristics.

Join the batches in linked list and flatten the list to a
path list during draw time.

Replace GrPathRendering::drawPath with GrPathRendering::drawPaths.

Perf changes ARM, Shield TV device, Tegra X1 GPU:
                desk_chalkboard.skp_1	21.5ms -> 17.8ms	0.83x
                    desk_mapsvg.skp_1	7.49ms -> 6.18ms	0.82x
Others results are more volatile.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22
==========