Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190843002: getFactory() must return a factory. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

getFactory() must return a factory. BUG=348821 Committed: http://code.google.com/p/skia/source/detail?r=13702

Patch Set 1 #

Patch Set 2 : invert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M src/core/SkWriteBuffer.cpp View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
ja lgtm
6 years, 9 months ago (2014-03-07 14:21:33 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-07 14:22:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/190843002/20001
6 years, 9 months ago (2014-03-07 14:25:03 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 14:52:15 UTC) #4
Message was sent while issue was closed. 
Change committed as 13702

Powered by Google App Engine
This is Rietveld 408576698