Allow content embedders to create AudioManager.

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 37 matching lines @@
 
 namespace blink {
 struct WebWindowFeatures;
 }
 
 namespace gfx {
 class ImageSkia;
 }
 
 namespace media {
+class AudioLogFactory;
+class AudioManager;
 class CdmFactory;
 }
 
 namespace shell {
 class ShellClient;
 }
 
 namespace net {
 class CookieOptions;
 class NetLog;
@@ skipping 630 matching lines @@
   virtual void RecordURLMetric(const std::string& metric, const GURL& url) {}
 
   // Allows the embedder to register one or more NavigationThrottles for the
   // navigation indicated by |navigation_handle|.  A NavigationThrottle is used
   // to control the flow of a navigation on the UI thread. The embedder is
   // guaranteed that the throttles will be executed in the order they were
   // provided.
   virtual ScopedVector<NavigationThrottle> CreateThrottlesForNavigation(
       NavigationHandle* navigation_handle);
 
+  // Allows the embedder to provide its own AudioManager implementation.
+  // If this function returns NULL, a default platform implementation will be

[jam, 2016/04/25 15:40:47]

nit: nullptr

[alokp, 2016/04/25 16:59:53]

Done.

+  // used. The caller owns the returned AudioManager instance.
+  virtual media::AudioManager* CreateAudioManager(

[DaleCurtis, 2016/04/22 23:45:06]

If caller owns, should return a scoped_ptr?

[alokp, 2016/04/22 23:54:21]

Since we are using ScopedAudioManagerPtr, it would require including
media/audio/audio_manager.h unnecessarily in content/public. This seems to be a
common pattern in this file to avoid including stuff.

[jam, 2016/04/25 15:40:47]

it's definitely fine to include headers from "lower-level" modules like
net/media/cc etc in content/public. So feel free to include that to make
ownership clearer.

[alokp, 2016/04/25 16:59:53]

DONE. I had to update DEPS - PTAL.

+      media::AudioLogFactory* audio_log_factory);
   // Creates and returns a factory used for creating CDM instances for playing
   // protected content.
   virtual std::unique_ptr<media::CdmFactory> CreateCdmFactory();
 
   // Populates |mappings| with all files that need to be mapped before launching
   // a child process.
 #if defined(OS_ANDROID)
   virtual void GetAdditionalMappedFilesForChildProcess(
       const base::CommandLine& command_line,
       int child_process_id,
@@ skipping 35 matching lines @@
   // Allows an embedder to provide its own ExternalVideoSurfaceContainer
   // implementation.  Return nullptr to disable external surface video.
   virtual ExternalVideoSurfaceContainer*
   OverrideCreateExternalVideoSurfaceContainer(WebContents* web_contents);
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_