Fix switching interceptor if element needs to upgraded after custom element is registered

Fix switching interceptor if element needs to upgraded after custom element is registered

R=jacobr@google.com

Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=c1840828d0445beb8c0482f92cd6bec830813c1e

[Jacob, 2016-04-22 16:46:16]

lgtm

https://codereview.chromium.org/1908423004/diff/1/Source/bindings/core/dart/D...
File Source/bindings/core/dart/DartJsInterop.cpp (right):

https://codereview.chromium.org/1908423004/diff/1/Source/bindings/core/dart/D...
Source/bindings/core/dart/DartJsInterop.cpp:1737:
ASSERT(!Dart_IsError(customType));
no need to have both the IsType and not IsError asserts.

https://codereview.chromium.org/1908423004/diff/1/Source/bindings/core/dart/D...
Source/bindings/core/dart/DartJsInterop.cpp:1739: bool equal;
For safety change to
bool equal = false;
as you aren't checking whether Dart_ObjectEquals blows up.

[terry, 2016-04-22 18:48:30]

Thanks.

Also, added caching of the wrapper before calling the created constructor in
case JS is called too.

https://codereview.chromium.org/1908423004/diff/1/Source/bindings/core/dart/D...
File Source/bindings/core/dart/DartJsInterop.cpp (right):

https://codereview.chromium.org/1908423004/diff/1/Source/bindings/core/dart/D...
Source/bindings/core/dart/DartJsInterop.cpp:1737:
ASSERT(!Dart_IsError(customType));
On 2016/04/22 16:46:16, Jacob wrote:
> no need to have both the IsType and not IsError asserts.

Yep, eliminated Dart_IsError.

https://codereview.chromium.org/1908423004/diff/1/Source/bindings/core/dart/D...
Source/bindings/core/dart/DartJsInterop.cpp:1739: bool equal;
On 2016/04/22 16:46:16, Jacob wrote:
> For safety change to
> bool equal = false;
> as you aren't checking whether Dart_ObjectEquals blows up.

Done.

[terry, 2016-04-22 18:49:33]

Issue https://github.com/dart-lang/sdk/issues/26228

[terry, 2016-04-22 19:09:11]

Description was changed from

==========
Fix switching interceptor if element needs to upgraded after custom element is
registered

R=jacobr@google.com
==========

to

==========
Fix switching interceptor if element needs to upgraded after custom element is
registered

R=jacobr@google.com

Committed:
https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision...
==========

[terry, 2016-04-22 19:09:13]

Committed patchset #3 (id:40001) manually as
c1840828d0445beb8c0482f92cd6bec830813c1e (tree was closed).