third_party/WebKit/Source/core/editing/Selection.idl - Issue 1908423003: Make Selection.prototype.toString() enumerable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 1908423003: Make Selection.prototype.toString() enumerable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Selection.idl

diff --git a/third_party/WebKit/Source/core/editing/Selection.idl b/third_party/WebKit/Source/core/editing/Selection.idl

index 19be361c58dc0cdc7ef4ef360c931ce40ae1450d..b6f216f57fbbc88af72a2c255fff2c20e47083e1 100644

--- a/third_party/WebKit/Source/core/editing/Selection.idl

+++ b/third_party/WebKit/Source/core/editing/Selection.idl

@@ -58,10 +58,7 @@

[MeasureAs=SelectionSelectAllChildren, RaisesException] void selectAllChildren(Node node);

[MeasureAs=SelectionDeleteDromDocument, CustomElementCallbacks] void deleteFromDocument();

[MeasureAs=SelectionContainsNode] boolean containsNode(Node node, optional boolean allowPartialContainment = false);

- // TODO(philipj): The spec does not use [NotEnumerable]. See also:

- // https://codereview.chromium.org/345983004/

- // https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179

- [MeasureAs=SelectionDOMString, NotEnumerable] stringifier DOMString();

+ [MeasureAs=SelectionDOMString] stringifier;

// Non-standard APIs