Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html

Issue 1908423003: Make Selection.prototype.toString() enumerable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html
diff --git a/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html b/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html
index 05493cadaf3080ae68eaf8ea507dcb3b4bc9203d..b322ebc854b1776c22911a3c3daf7fa3f06a74c6 100644
--- a/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html
+++ b/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html
@@ -26,7 +26,8 @@
// DOM objects with custom toString() functions
test(window.location, "Location");
- test(window.getSelection(), "Selection");
+ // Legacy, toString() kept as non-enumerable.
sof 2016/04/22 19:19:45 I couldn't find coverage for WebKitCSSMatrix' toSt
yoichio 2016/04/25 02:13:43 Could you split this to another CL?
sof 2016/04/25 05:40:27 removed from here.
+ test(window.WebKitCSSMatrix.prototype, "WebKitCSSMatrix");
// Other DOM objects
test(document.createElement('div'), "HTMLDivElement");

Powered by Google App Engine
This is Rietveld 408576698