Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1908423003: Make Selection.prototype.toString() enumerable. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
yoichio, philipj_slow
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Selection.prototype.toString() enumerable. The stringifier for Selection is enumerable, https://w3c.github.io/selection-api/#idl-def-Selection so align with spec and other implementations, and remove the use of [NotEnumerable]. R=yoichio BUG=306606 Committed: https://crrev.com/d15884468d75721f312dacb2d5326a8c60f2ed54 Cr-Commit-Position: refs/heads/master@{#389427}

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 3

Patch Set 3 : remove WebKitCSSMatrix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/Selection/selection-interface.html View 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/toString-dontEnum-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Selection.idl View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
please take a look. this aligns with spec + FF & Edge. https://codereview.chromium.org/1908423003/diff/20001/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html File third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html ...
4 years, 8 months ago (2016-04-22 19:19:45 UTC) #2
yoichio
https://codereview.chromium.org/1908423003/diff/20001/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html File third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html (right): https://codereview.chromium.org/1908423003/diff/20001/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html#newcode29 third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html:29: // Legacy, toString() kept as non-enumerable. On 2016/04/22 19:19:45, ...
4 years, 8 months ago (2016-04-25 02:13:43 UTC) #3
sof
https://codereview.chromium.org/1908423003/diff/20001/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html File third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html (right): https://codereview.chromium.org/1908423003/diff/20001/third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html#newcode29 third_party/WebKit/LayoutTests/fast/js/toString-dontEnum.html:29: // Legacy, toString() kept as non-enumerable. On 2016/04/25 02:13:43, ...
4 years, 8 months ago (2016-04-25 05:40:27 UTC) #4
yoichio
lgtm
4 years, 8 months ago (2016-04-25 06:49:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908423003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908423003/40001
4 years, 8 months ago (2016-04-25 06:55:55 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-25 08:01:17 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 08:02:33 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d15884468d75721f312dacb2d5326a8c60f2ed54
Cr-Commit-Position: refs/heads/master@{#389427}

Powered by Google App Engine
This is Rietveld 408576698