Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 1908423002: Revert of SkStringPrintf and SkString::printf now are no longer limted by a static buffer (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
tomhudson, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkStringPrintf and SkString::printf now are no longer limted by a static buffer (patchset #5 id:80001 of https://codereview.chromium.org/1403803002/ ) Reason for revert: breaking something Original issue's description: > SkStringPrintf and SkString::printf now are no longer limted by a static buffer > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1403803002 > > Committed: https://skia.googlesource.com/skia/+/606cadd5aac62299ef2e277709b3684cae2bf96c TBR=tomhudson@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/3361e6248b415bb3054b5af6462666f1608e0765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -82 lines) Patch
M src/core/SkString.cpp View 3 chunks +9 lines, -52 lines 0 comments Download
M src/pdf/SkPDFMetadata.cpp View 3 chunks +52 lines, -4 lines 0 comments Download
M tests/StringTest.cpp View 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hal.canary
Created Revert of SkStringPrintf and SkString::printf now are no longer limted by a static buffer
4 years, 8 months ago (2016-04-22 15:18:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908423002/1
4 years, 8 months ago (2016-04-22 15:18:59 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 15:19:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3361e6248b415bb3054b5af6462666f1608e0765

Powered by Google App Engine
This is Rietveld 408576698