Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

Issue 1908393002: Don't allow column spanners inside transforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/span/invalid-spanner-in-transform-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
index ea48c2380e124d0da0c44b8e16061b2ed5f886ba..f48795d9ccfb7304f4577bac707002cf80a41cc9 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
@@ -87,6 +87,7 @@ static inline bool canContainSpannerInParentFragmentationContext(const LayoutObj
return false;
const LayoutBlockFlow& blockFlow = toLayoutBlockFlow(object);
return !blockFlow.createsNewFormattingContext()
+ && !blockFlow.hasTransformRelatedProperty()
eae 2016/04/22 16:52:23 Could you please add a comment to this method that
mstensho (USE GERRIT) 2016/04/22 17:44:39 Done.
&& blockFlow.getPaginationBreakability() != LayoutBox::ForbidBreaks
&& !isMultiColumnContainer(blockFlow);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/span/invalid-spanner-in-transform-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698