Don't allow column spanners inside transforms.

Don't allow column spanners inside transforms.

Spanners want the multicol container as their containing block. Transforms want
to be the containing block of everything inside. Since it's not possible to
fulfill both wishes, just refuse objects to become spanners when inside
transforms. We already do the same when inside out-of-flow objects, and also
for anything that establishes a new formatting context.

BUG=596863
Committed: https://crrev.com/e704e736d1dd462a20930d09e311e350c1a7724c
Cr-Commit-Position: refs/heads/master@{#389207}

[mstensho (USE GERRIT), 2016-04-22 16:08:01]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, leviw@chromium.org, szager@chromium.org,
wkorman@chromium.org

[eae, 2016-04-22 16:52:23]

LGTM

https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
(right):

https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:90: &&
!blockFlow.hasTransformRelatedProperty()
Could you please add a comment to this method that explains the logic? Something
like the CL description would be great.

[mstensho (USE GERRIT), 2016-04-22 17:44:39]

https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
(right):

https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:90: &&
!blockFlow.hasTransformRelatedProperty()
On 2016/04/22 16:52:23, eae wrote:
> Could you please add a comment to this method that explains the logic?
Something
> like the CL description would be great.

Done.

[mstensho (USE GERRIT), 2016-04-22 17:44:51]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-04-22 17:44:52]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1908393002/#ps20001
(title: "Documentation.")

[commit-bot: I haz the power, 2016-04-22 17:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908393002/20001

[commit-bot: I haz the power, 2016-04-22 19:25:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:51:39]

Description was changed from

==========
Don't allow column spanners inside transforms.

Spanners want the multicol container as their containing block. Transforms want
to be the containing block of everything inside. Since it's not possible to
fulfill both wishes, just refuse objects to become spanners when inside
transforms. We already do the same when inside out-of-flow objects, and also
for anything that establishes a new formatting context.

BUG=596863
==========

to

==========
Don't allow column spanners inside transforms.

Spanners want the multicol container as their containing block. Transforms want
to be the containing block of everything inside. Since it's not possible to
fulfill both wishes, just refuse objects to become spanners when inside
transforms. We already do the same when inside out-of-flow objects, and also
for anything that establishes a new formatting context.

BUG=596863

Committed: https://crrev.com/e704e736d1dd462a20930d09e311e350c1a7724c
Cr-Commit-Position: refs/heads/master@{#389207}
==========

[commit-bot: I haz the power, 2016-04-22 19:51:40]

Patchset 2 (id:??) landed as
https://crrev.com/e704e736d1dd462a20930d09e311e350c1a7724c
Cr-Commit-Position: refs/heads/master@{#389207}