Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1908393002: Don't allow column spanners inside transforms. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow column spanners inside transforms. Spanners want the multicol container as their containing block. Transforms want to be the containing block of everything inside. Since it's not possible to fulfill both wishes, just refuse objects to become spanners when inside transforms. We already do the same when inside out-of-flow objects, and also for anything that establishes a new formatting context. BUG=596863 Committed: https://crrev.com/e704e736d1dd462a20930d09e311e350c1a7724c Cr-Commit-Position: refs/heads/master@{#389207}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/invalid-spanner-in-transform.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/invalid-spanner-in-transform-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-22 16:08:02 UTC) #2
eae
LGTM https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp (right): https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp#newcode90 third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:90: && !blockFlow.hasTransformRelatedProperty() Could you please add a comment ...
4 years, 8 months ago (2016-04-22 16:52:23 UTC) #3
mstensho (USE GERRIT)
https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp File third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp (right): https://codereview.chromium.org/1908393002/diff/1/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp#newcode90 third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp:90: && !blockFlow.hasTransformRelatedProperty() On 2016/04/22 16:52:23, eae wrote: > Could ...
4 years, 8 months ago (2016-04-22 17:44:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908393002/20001
4 years, 8 months ago (2016-04-22 17:45:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 19:25:24 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:51:40 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e704e736d1dd462a20930d09e311e350c1a7724c
Cr-Commit-Position: refs/heads/master@{#389207}

Powered by Google App Engine
This is Rietveld 408576698