Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1908373003: Rename EtwSystemEventConsumerWin to EtwTracingAgent (Closed)

Created:
4 years, 8 months ago by charliea (OOO until 10-5)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename EtwSystemEventConsumerWin to EtwTracingAgent This brings it up to speed with our present naming, where classes that inherit from TracingAgent end with TracingAgent themselves. Committed: https://crrev.com/b06896ff781a20c151d82bc315ddfb4c43cd5438 Cr-Commit-Position: refs/heads/master@{#389895}

Patch Set 1 #

Patch Set 2 : Checking if the _win suffix makes a difference #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -377 lines) Patch
M base/trace_event/tracing_agent.h View 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/tracing/etw_system_event_consumer_win.h View 1 chunk +0 lines, -83 lines 0 comments Download
D content/browser/tracing/etw_system_event_consumer_win.cc View 1 chunk +0 lines, -255 lines 0 comments Download
A + content/browser/tracing/etw_tracing_agent_win.h View 1 2 4 chunks +11 lines, -11 lines 0 comments Download
A + content/browser/tracing/etw_tracing_agent_win.cc View 1 2 11 chunks +21 lines, -21 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373003/1
4 years, 8 months ago (2016-04-22 21:07:18 UTC) #2
charliea (OOO until 10-5)
4 years, 8 months ago (2016-04-22 21:07:29 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/149660) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 8 months ago (2016-04-22 21:20:36 UTC) #6
oystein (OOO til 10th of July)
lgtm (assuming compile fix, of course :) )
4 years, 8 months ago (2016-04-22 21:33:44 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373003/20001
4 years, 8 months ago (2016-04-22 21:46:25 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/179486)
4 years, 8 months ago (2016-04-22 22:38:02 UTC) #11
fdoray
I think you forgot to add etw_tracing_agent_win.cc/.h.
4 years, 8 months ago (2016-04-25 14:06:06 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373003/40001
4 years, 8 months ago (2016-04-25 14:28:39 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/127119) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 8 months ago (2016-04-25 14:34:56 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373003/40001
4 years, 8 months ago (2016-04-26 13:16:44 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 14:21:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908373003/40001
4 years, 8 months ago (2016-04-26 20:30:29 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 21:30:19 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:31:22 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b06896ff781a20c151d82bc315ddfb4c43cd5438
Cr-Commit-Position: refs/heads/master@{#389895}

Powered by Google App Engine
This is Rietveld 408576698