Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4271)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1908363002: Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: restore test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 017d081cabb6c8b4f4312aa95d1b5ab9e5aa19d2..93c057d13723ef678e322ff0ac1f0cf2b305f586 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -2012,27 +2012,6 @@ void Browser::ConfirmAddSearchProvider(TemplateURL* template_url,
///////////////////////////////////////////////////////////////////////////////
// Browser, SearchTabHelperDelegate implementation:
-void Browser::NavigateOnThumbnailClick(const GURL& url,
- WindowOpenDisposition disposition,
- content::WebContents* source_contents) {
- DCHECK(source_contents);
- // We're guaranteed that AUTO_BOOKMARK is the right transition since this only
- // gets called to handle clicks in the new tab page (to navigate to most
- // visited item URLs) and in the search results page (to navigate to
- // privileged destinations (e.g. chrome://URLs)).
- //
- // TODO(kmadhusu): Page transitions to privileged destinations should be
- // marked as "LINK" instead of "AUTO_BOOKMARK"?
- chrome::NavigateParams params(this, url,
- ui::PAGE_TRANSITION_AUTO_BOOKMARK);
- params.referrer = content::Referrer();
- params.source_contents = source_contents;
- params.disposition = disposition;
- params.is_renderer_initiated = false;
- params.initiating_profile = profile_;
- chrome::Navigate(&params);
-}
-
void Browser::OnWebContentsInstantSupportDisabled(
const content::WebContents* web_contents) {
DCHECK(web_contents);

Powered by Google App Engine
This is Rietveld 408576698