Shift visual-to-flowthread coordinate space conversion one level up in the tree.

Shift visual-to-flowthread coordinate space conversion one level up in the tree.

The same was done for the opposite operation, i.e. flowthread-to-visual
coordinate space conversion, in mapLocalToAncestor(), in
https://codereview.chromium.org/1819603003 . Let's do the same in
mapAncestorToLocal(), so that we're more consistent. This doesn't fix any known
bugs, but it sure makes sense that mapLocalToAncestor() be the opposite of
mapAncestorToLocal(). This also makes it less of a headache to write unit
tests, since you can now feed transformState1 into
obj->mapLocalToAncestor(parent) and get transformState2 back, then feed
transformState2 into obj->mapAncestorToLocal(parent) and then be back at
transformState1.

Committed: https://crrev.com/3cf60f451a7af9826083b316811ce9bbb2479ad5
Cr-Commit-Position: refs/heads/master@{#389143}

[mstensho (USE GERRIT), 2016-04-22 13:14:13]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, leviw@chromium.org, szager@chromium.org,
wkorman@chromium.org

[eae, 2016-04-22 16:53:52]

I like it, thank you!
LGTM

[eae, 2016-04-22 16:53:58]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-04-22 16:54:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908353002/1

[commit-bot: I haz the power, 2016-04-22 16:58:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:48:53]

Description was changed from

==========
Shift visual-to-flowthread coordinate space conversion one level up in the tree.

The same was done for the opposite operation, i.e. flowthread-to-visual
coordinate space conversion, in mapLocalToAncestor(), in
https://codereview.chromium.org/1819603003 . Let's do the same in
mapAncestorToLocal(), so that we're more consistent. This doesn't fix any known
bugs, but it sure makes sense that mapLocalToAncestor() be the opposite of
mapAncestorToLocal(). This also makes it less of a headache to write unit
tests, since you can now feed transformState1 into
obj->mapLocalToAncestor(parent) and get transformState2 back, then feed
transformState2 into obj->mapAncestorToLocal(parent) and then be back at
transformState1.
==========

to

==========
Shift visual-to-flowthread coordinate space conversion one level up in the tree.

The same was done for the opposite operation, i.e. flowthread-to-visual
coordinate space conversion, in mapLocalToAncestor(), in
https://codereview.chromium.org/1819603003 . Let's do the same in
mapAncestorToLocal(), so that we're more consistent. This doesn't fix any known
bugs, but it sure makes sense that mapLocalToAncestor() be the opposite of
mapAncestorToLocal(). This also makes it less of a headache to write unit
tests, since you can now feed transformState1 into
obj->mapLocalToAncestor(parent) and get transformState2 back, then feed
transformState2 into obj->mapAncestorToLocal(parent) and then be back at
transformState1.

Committed: https://crrev.com/3cf60f451a7af9826083b316811ce9bbb2479ad5
Cr-Commit-Position: refs/heads/master@{#389143}
==========

[commit-bot: I haz the power, 2016-04-22 19:48:54]

Patchset 1 (id:??) landed as
https://crrev.com/3cf60f451a7af9826083b316811ce9bbb2479ad5
Cr-Commit-Position: refs/heads/master@{#389143}