Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1908313002: ARC: add histogram definition for ShutdownTime (Closed)

Created:
4 years, 8 months ago by elijahtaylor1
Modified:
4 years, 8 months ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARC: add histogram definition for ShutdownTime BUG=605811 Committed: https://crrev.com/e794bb52914b5dd9b440776c56bbe09f4f3a9930 Cr-Commit-Position: refs/heads/master@{#389319}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
elijahtaylor1
hi, PTAL. The guts of where this data is collected is here (requires internal chrome ...
4 years, 8 months ago (2016-04-22 01:37:45 UTC) #3
jwd
https://codereview.chromium.org/1908313002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1908313002/diff/1/tools/metrics/histograms/histograms.xml#newcode931 tools/metrics/histograms/histograms.xml:931: + <summary>The time it takes for ARC to shut ...
4 years, 8 months ago (2016-04-22 14:59:02 UTC) #4
elijahtaylor1
PTAL https://codereview.chromium.org/1908313002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1908313002/diff/1/tools/metrics/histograms/histograms.xml#newcode931 tools/metrics/histograms/histograms.xml:931: + <summary>The time it takes for ARC to ...
4 years, 8 months ago (2016-04-22 16:55:49 UTC) #5
jwd
lgtm
4 years, 8 months ago (2016-04-22 18:47:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908313002/20001
4 years, 8 months ago (2016-04-22 23:05:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-23 00:09:44 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 00:10:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e794bb52914b5dd9b440776c56bbe09f4f3a9930
Cr-Commit-Position: refs/heads/master@{#389319}

Powered by Google App Engine
This is Rietveld 408576698