Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1908273002:
[tools] fix target_name ordering bug in generate_compiled_resources_gyp.py (Closed)
|
Created:
4 years, 8 months ago by Dan Beam Modified:
4 years, 8 months ago CC:
chromium-reviews, vitalyp+closure_chromium.org, michaelpg+watch-polymer_chromium.org, dbeam+watch-polymer_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[tools] fix target_name ordering bug in generate_compiled_resources_gyp.py
R=dschuyler@chromium.org
BUG=605791
NOTRY=true
Committed: https://crrev.com/57c67380298b9c48a1f8d429b2b55c56defaa9af
Cr-Commit-Position: refs/heads/master@{#388988}
Patch Set 1 : whoops #
Total comments: 2
Patch Set 2 : nit #Messages
Total messages: 19 (10 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.rog BUG=605791 ========== to ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.rog BUG=605791 ==========
dbeam@chromium.org changed reviewers: + dschuyler@chromium.org - dschuyler@chromium.rog
Description was changed from ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.rog BUG=605791 ========== to ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.org BUG=605791 ==========
lgtm
dbeam@chromium.org changed reviewers: + michaelpg@chromium.org
+michaelpg@ for tools/polymer/OWNERS stuff like this is starting to creep in: https://codereview.chromium.org/1766433002/diff/50001/third_party/polymer/v1_... https://codereview.chromium.org/1901343004/diff/1/third_party/polymer/v1_0/co... my bad
Description was changed from ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.org BUG=605791 ========== to ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.org BUG=605791 NOTRY=true ==========
lgtm lgtm w question https://codereview.chromium.org/1908273002/diff/20001/tools/polymer/generate_... File tools/polymer/generate_compiled_resources_gyp.py (right): https://codereview.chromium.org/1908273002/diff/20001/tools/polymer/generate_... tools/polymer/generate_compiled_resources_gyp.py:39: for html_file in sorted(html_files, key=lambda h: _target_name(h)): is the lambda necessary, or can this be just "sorted(html_files, key=_target_name)"
https://codereview.chromium.org/1908273002/diff/20001/tools/polymer/generate_... File tools/polymer/generate_compiled_resources_gyp.py (right): https://codereview.chromium.org/1908273002/diff/20001/tools/polymer/generate_... tools/polymer/generate_compiled_resources_gyp.py:39: for html_file in sorted(html_files, key=lambda h: _target_name(h)): On 2016/04/22 00:49:04, michaelpg wrote: > is the lambda necessary, or can this be just "sorted(html_files, > key=_target_name)" Done.
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dschuyler@chromium.org, michaelpg@chromium.org Link to the patchset: https://codereview.chromium.org/1908273002/#ps40001 (title: "nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908273002/40001
Message was sent while issue was closed.
Description was changed from ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.org BUG=605791 NOTRY=true ========== to ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.org BUG=605791 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.org BUG=605791 NOTRY=true ========== to ========== [tools] fix target_name ordering bug in generate_compiled_resources_gyp.py R=dschuyler@chromium.org BUG=605791 NOTRY=true Committed: https://crrev.com/57c67380298b9c48a1f8d429b2b55c56defaa9af Cr-Commit-Position: refs/heads/master@{#388988} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/57c67380298b9c48a1f8d429b2b55c56defaa9af Cr-Commit-Position: refs/heads/master@{#388988} |
