third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp - Issue 1908263002: Don't expose URL.createObjectURL and revokeObjectURL to Service Workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp

Issue 1908263002: Don't expose URL.createObjectURL and revokeObjectURL to Service Workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update expectations/update fetch tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/scheme-blob.js ('K') | « third_party/WebKit/Source/modules/mediasource/URLMediaSource.idl ('k') | third_party/WebKit/Source/modules/mediastream/URLMediaStream.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp b/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp

index d552d043670140bc0a7452ad28041fa289c52861..8f10116f5b25c89907e2bc90f05b3842895cbf5f 100644

--- a/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp

@@ -31,8 +31,6 @@

#include "modules/mediastream/URLMediaStream.h"

#include "core/dom/DOMURL.h"

-#include "core/frame/Deprecation.h"

-#include "core/frame/UseCounter.h"

#include "modules/mediastream/MediaStream.h"

namespace blink {

@@ -42,9 +40,6 @@ String URLMediaStream::createObjectURL(ExecutionContext* executionContext, Media

// Since WebWorkers cannot obtain Stream objects, we should be on the main thread.

DCHECK(isMainThread());

- if (executionContext && executionContext->isServiceWorkerGlobalScope())

- Deprecation::countDeprecation(executionContext, UseCounter::URLMethodCreateObjectURLServiceWorker);

if (!executionContext || !stream)

return String();

return DOMURL::createPublicURL(executionContext, stream);