Don't expose URL.createObjectURL and revokeObjectURL to Service Workers

third_party/WebKit/Source/core/fileapi/URLFileAPI.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/fileapi/URLFileAPI.h"
+
+#include "bindings/core/v8/ExceptionState.h"
+#include "core/dom/DOMURL.h"
+#include "core/dom/ExecutionContext.h"
+#include "core/fileapi/Blob.h"
+#include "core/html/PublicURLManager.h"
+
+namespace blink {
+
+// static
+String URLFileAPI::createObjectURL(ExecutionContext* executionContext, Blob* blob, ExceptionState& exceptionState)
+{
+    DCHECK(blob);
+    if (!executionContext)

[sof, 2016/04/22 06:19:29]

assert instead? i.e., can the current execution context being passed in ever be
null?

[jsbell, 2016/04/22 18:14:34]

That's how I found the code. :( I'll switch it to a DCHECK and see if it sticks.

+        return String();
+    if (blob->hasBeenClosed()) {
+        exceptionState.throwDOMException(InvalidStateError, String(blob->isFile() ? "File" : "Blob") + " has been closed.");
+        return String();
+    }
+    return DOMURL::createPublicURL(executionContext, blob, blob->uuid());
+}
+
+// static
+void URLFileAPI::revokeObjectURL(ExecutionContext* executionContext, const String& urlString)
+{
+    if (!executionContext)
+        return;
+
+    KURL url(KURL(), urlString);
+    executionContext->removeURLFromMemoryCache(url);
+    executionContext->publicURLManager().revoke(url);
+}
+
+} // namespace blink