Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1908253007: Fix cctest/test-run-load-store for big-endian architectures. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, JaideepBajwa, JoranSiu
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix cctest/test-run-load-store for big-endian architectures. R=bmeurer@chromium.org, titzer@chromium.org, ahaas@chromium.org BUG= Committed: https://crrev.com/36091039b3c18eb507ebdd4f96d6985b416ea7be Cr-Commit-Position: refs/heads/master@{#35765}

Patch Set 1 #

Patch Set 2 : add RunLoadStoreSignExtend64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M test/cctest/compiler/test-run-load-store.cc View 1 4 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-22 18:41:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908253007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908253007/20001
4 years, 8 months ago (2016-04-22 18:41:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 19:02:48 UTC) #6
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-23 11:58:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908253007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908253007/20001
4 years, 8 months ago (2016-04-25 13:38:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 14:01:04 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:01:37 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/36091039b3c18eb507ebdd4f96d6985b416ea7be
Cr-Commit-Position: refs/heads/master@{#35765}

Powered by Google App Engine
This is Rietveld 408576698