Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1908253005: Bluez: Move released profiles to a separate map. (Closed)

Created:
4 years, 8 months ago by stevenjb
Modified:
4 years, 8 months ago
Reviewers:
rkc, scheib, ortuno
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bluez: Move released profiles to a separate map. This addresses an edge case where released profiles may not have been removed before Shutdown. See issue for details. BUG=604710 Committed: https://crrev.com/3bfed672ec31b7f51390da4c6ba260942ea8df25 Cr-Commit-Position: refs/heads/master@{#389242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M device/bluetooth/bluez/bluetooth_adapter_bluez.h View 1 chunk +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 2 chunks +25 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
stevenjb
4 years, 8 months ago (2016-04-22 17:48:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908253005/1
4 years, 8 months ago (2016-04-22 17:49:38 UTC) #4
rkc
lgtm nit: This can also be done by re-using the profile vector to store a ...
4 years, 8 months ago (2016-04-22 19:37:17 UTC) #5
stevenjb
On 2016/04/22 19:37:17, Rahul Chaturvedi wrote: > lgtm > > nit: This can also be ...
4 years, 8 months ago (2016-04-22 19:49:17 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 20:25:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908253005/1
4 years, 8 months ago (2016-04-22 20:32:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/172218)
4 years, 8 months ago (2016-04-22 20:48:38 UTC) #12
stevenjb
scheib@ or ortuno@, I need an owner lg.
4 years, 8 months ago (2016-04-22 21:00:15 UTC) #14
ortuno
lgtm
4 years, 8 months ago (2016-04-22 21:11:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908253005/1
4 years, 8 months ago (2016-04-22 21:14:51 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 21:20:16 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 21:21:34 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bfed672ec31b7f51390da4c6ba260942ea8df25
Cr-Commit-Position: refs/heads/master@{#389242}

Powered by Google App Engine
This is Rietveld 408576698