Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: components/test_runner/layout_test_runtime_flags.h

Issue 1908233002: One and only one top-loading-frame across all renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split-setTopLoadingFrame-into-set-and-clear
Patch Set: Comment tweak on |have_top_loading_frame| flag. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/test_runner/layout_test_runtime_flags.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TEST_RUNNER_LAYOUT_TEST_RUNTIME_FLAGS_H_ 5 #ifndef COMPONENTS_TEST_RUNNER_LAYOUT_TEST_RUNTIME_FLAGS_H_
6 #define COMPONENTS_TEST_RUNNER_LAYOUT_TEST_RUNTIME_FLAGS_H_ 6 #define COMPONENTS_TEST_RUNNER_LAYOUT_TEST_RUNTIME_FLAGS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 // If true, output a message when the page title is changed. 151 // If true, output a message when the page title is changed.
152 DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(dump_title_changes) 152 DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(dump_title_changes)
153 153
154 // If true, the test_shell will print out the icon change notifications. 154 // If true, the test_shell will print out the icon change notifications.
155 DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(dump_icon_changes) 155 DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(dump_icon_changes)
156 156
157 // Desired return value of WebFrameClient::runModalBeforeUnloadDialog. 157 // Desired return value of WebFrameClient::runModalBeforeUnloadDialog.
158 DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG( 158 DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(
159 stay_on_page_after_handling_before_unload) 159 stay_on_page_after_handling_before_unload)
160 160
161 // Indicates if the test already tracks a top loading frame (in any of the
162 // renderer processes). This flag is trying to prevent different renderer
163 // processes from tracking different top loading frames (i.e. main frame in
164 // one renderer and an OOPIF in another renderer).
165 DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG(have_top_loading_frame)
166
161 #undef DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG 167 #undef DEFINE_BOOL_LAYOUT_TEST_RUNTIME_FLAG
162 #undef DEFINE_STRING_LAYOUT_TEST_RUNTIME_FLAG 168 #undef DEFINE_STRING_LAYOUT_TEST_RUNTIME_FLAG
163 169
164 // Reports whether recursing over child frames is necessary. 170 // Reports whether recursing over child frames is necessary.
165 bool dump_child_frames() const { 171 bool dump_child_frames() const {
166 if (dump_as_text()) 172 if (dump_as_text())
167 return dump_child_frames_as_text(); 173 return dump_child_frames_as_text();
168 else if (dump_as_markup()) 174 else if (dump_as_markup())
169 return dump_child_frames_as_markup(); 175 return dump_child_frames_as_markup();
170 else 176 else
171 return dump_child_frame_scroll_positions(); 177 return dump_child_frame_scroll_positions();
172 } 178 }
173 179
174 private: 180 private:
175 TrackedDictionary dict_; 181 TrackedDictionary dict_;
176 182
177 DISALLOW_COPY_AND_ASSIGN(LayoutTestRuntimeFlags); 183 DISALLOW_COPY_AND_ASSIGN(LayoutTestRuntimeFlags);
178 }; 184 };
179 185
180 } // namespace test_runner 186 } // namespace test_runner
181 187
182 #endif // COMPONENTS_TEST_RUNNER_LAYOUT_TEST_RUNTIME_FLAGS_H_ 188 #endif // COMPONENTS_TEST_RUNNER_LAYOUT_TEST_RUNTIME_FLAGS_H_
OLDNEW
« no previous file with comments | « no previous file | components/test_runner/layout_test_runtime_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698