Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 190823002: Update constant pool correctly when resuming a generator (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add new scope for ConstantPoolUnavailableScope Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2176 matching lines...) Expand 10 before | Expand all | Expand 10 after
2187 __ ldr(r3, FieldMemOperand(r3, FixedArray::kLengthOffset)); 2187 __ ldr(r3, FieldMemOperand(r3, FixedArray::kLengthOffset));
2188 __ SmiUntag(r3); 2188 __ SmiUntag(r3);
2189 2189
2190 // If we are sending a value and there is no operand stack, we can jump back 2190 // If we are sending a value and there is no operand stack, we can jump back
2191 // in directly. 2191 // in directly.
2192 if (resume_mode == JSGeneratorObject::NEXT) { 2192 if (resume_mode == JSGeneratorObject::NEXT) {
2193 Label slow_resume; 2193 Label slow_resume;
2194 __ cmp(r3, Operand(0)); 2194 __ cmp(r3, Operand(0));
2195 __ b(ne, &slow_resume); 2195 __ b(ne, &slow_resume);
2196 __ ldr(r3, FieldMemOperand(r4, JSFunction::kCodeEntryOffset)); 2196 __ ldr(r3, FieldMemOperand(r4, JSFunction::kCodeEntryOffset));
2197 __ ldr(r2, FieldMemOperand(r1, JSGeneratorObject::kContinuationOffset)); 2197
2198 __ SmiUntag(r2); 2198 { ConstantPoolUnavailableScope constant_pool_unavailable(masm_);
2199 __ add(r3, r3, r2); 2199 if (FLAG_enable_ool_constant_pool) {
2200 __ mov(r2, Operand(Smi::FromInt(JSGeneratorObject::kGeneratorExecuting))); 2200 // Load the new code object's constant pool pointer.
2201 __ str(r2, FieldMemOperand(r1, JSGeneratorObject::kContinuationOffset)); 2201 __ ldr(pp,
2202 __ Jump(r3); 2202 MemOperand(r3, Code::kConstantPoolOffset - Code::kHeaderSize));
2203 }
2204
2205 __ ldr(r2, FieldMemOperand(r1, JSGeneratorObject::kContinuationOffset));
2206 __ SmiUntag(r2);
2207 __ add(r3, r3, r2);
2208 __ mov(r2, Operand(Smi::FromInt(JSGeneratorObject::kGeneratorExecuting)));
2209 __ str(r2, FieldMemOperand(r1, JSGeneratorObject::kContinuationOffset));
2210 __ Jump(r3);
2211 }
2203 __ bind(&slow_resume); 2212 __ bind(&slow_resume);
2204 } 2213 }
2205 2214
2206 // Otherwise, we push holes for the operand stack and call the runtime to fix 2215 // Otherwise, we push holes for the operand stack and call the runtime to fix
2207 // up the stack and the handlers. 2216 // up the stack and the handlers.
2208 Label push_operand_holes, call_resume; 2217 Label push_operand_holes, call_resume;
2209 __ bind(&push_operand_holes); 2218 __ bind(&push_operand_holes);
2210 __ sub(r3, r3, Operand(1), SetCC); 2219 __ sub(r3, r3, Operand(1), SetCC);
2211 __ b(mi, &call_resume); 2220 __ b(mi, &call_resume);
2212 __ push(r2); 2221 __ push(r2);
(...skipping 2704 matching lines...) Expand 10 before | Expand all | Expand 10 after
4917 ASSERT(Memory::uint32_at(interrupt_address_pointer) == 4926 ASSERT(Memory::uint32_at(interrupt_address_pointer) ==
4918 reinterpret_cast<uint32_t>( 4927 reinterpret_cast<uint32_t>(
4919 isolate->builtins()->OsrAfterStackCheck()->entry())); 4928 isolate->builtins()->OsrAfterStackCheck()->entry()));
4920 return OSR_AFTER_STACK_CHECK; 4929 return OSR_AFTER_STACK_CHECK;
4921 } 4930 }
4922 4931
4923 4932
4924 } } // namespace v8::internal 4933 } } // namespace v8::internal
4925 4934
4926 #endif // V8_TARGET_ARCH_ARM 4935 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698