[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js. The
operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832
Committed: https://crrev.com/4cdc2945869f26e2394e9f05b5564613c53d42d0
Cr-Commit-Position: refs/heads/master@{#390923}

[yhirano, 2016-04-22 10:48:40]

Description was changed from

==========
[Streams] SetDisturbed should be defined on reader, not stream

BUG=596832
==========

to

==========
[Streams] SetDisturbed should be defined on reader, not on stream

BUG=596832
==========

[yhirano, 2016-04-25 06:17:23]

yhirano@chromium.org changed reviewers:
+ domenic@chromium.org

[yhirano, 2016-04-25 06:17:24]

Domenic, is this what you suggested at
https://codereview.chromium.org/1898873003/#msg10 ?

[yhirano, 2016-04-25 06:20:03]

(Note: this CL depends on https://codereview.chromium.org/1899873006/ which was
once landed but reverted after that. I'm currently trying to reland it).

[domenic, 2016-04-25 16:16:23]

On 2016/04/25 at 06:17:24, yhirano wrote:
> Domenic, is this what you suggested at
https://codereview.chromium.org/1898873003/#msg10 ?

Not quite. What I was confused about is why you ever need to do setDisturbed at
all. Can't you just rely on read()ing or cancel()ing the stream (via a reader)
to cause it to be disturbed? Why do you need to reach in directly and modify the
bit field?

[yhirano, 2016-04-26 01:40:37]

On 2016/04/25 16:16:23, domenic wrote:
> On 2016/04/25 at 06:17:24, yhirano wrote:
> > Domenic, is this what you suggested at
> https://codereview.chromium.org/1898873003/#msg10 ?
> 
> Not quite. What I was confused about is why you ever need to do setDisturbed
at
> all. Can't you just rely on read()ing or cancel()ing the stream (via a reader)
> to cause it to be disturbed? Why do you need to reach in directly and modify
the
> bit field?

I wanted to make it disturbed while not reading from UnderlyingSource. I've just
noticed I can do it by doing the following in order.

 1. Close the stream
 2. Acquire a lock
 3. Read data (=> no data will be consumed)

I will update the CL.

[yhirano, 2016-04-28 09:22:01]

Description was changed from

==========
[Streams] SetDisturbed should be defined on reader, not on stream

BUG=596832
==========

to

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js.
The operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and make a read call.

BUG=596832
==========

[yhirano, 2016-04-28 09:22:15]

Description was changed from

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js.
The operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and make a read call.

BUG=596832
==========

to

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js.
The operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832
==========

[yhirano, 2016-04-28 09:23:32]

Description was changed from

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js.
The operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832
==========

to

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js. The
operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832
==========

[yhirano, 2016-04-28 09:24:09]

Now it's ready. PTAL.

[domenic, 2016-04-28 19:06:40]

On 2016/04/28 at 09:24:09, yhirano wrote:
> Now it's ready. PTAL.

LGTM; thanks for taking the time to fix this!

[yhirano, 2016-05-02 09:31:56]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-05-02 09:32:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908213004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908213004/60001

[commit-bot: I haz the power, 2016-05-02 12:24:39]

Description was changed from

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js. The
operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832
==========

to

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js. The
operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832
==========

[commit-bot: I haz the power, 2016-05-02 12:24:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-02 12:26:16]

Description was changed from

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js. The
operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832
==========

to

==========
[Streams] Remove SetReadableStreamDisturbed from ReadableStream.js

This CL removes SetReadableStreamDisturbed from ReadableStream.js. The
operation is used to mark the stream disturbed while not pulling from
the source, but we can do that without the operation by closing
the stream first and then making a read call.

BUG=596832

Committed: https://crrev.com/4cdc2945869f26e2394e9f05b5564613c53d42d0
Cr-Commit-Position: refs/heads/master@{#390923}
==========

[commit-bot: I haz the power, 2016-05-02 12:26:17]

Patchset 4 (id:??) landed as
https://crrev.com/4cdc2945869f26e2394e9f05b5564613c53d42d0
Cr-Commit-Position: refs/heads/master@{#390923}